[PR #25] [MERGED] hotfix: do not return error when getting IconName and IconPixmap but log a warning to the output #25

Closed
opened 2026-05-22 22:04:52 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/system-tray/pull/25
Author: @ogios
Created: 7/21/2025
Status: Merged
Merged: 9/14/2025
Merged by: @JakeStanger

Base: masterHead: master


📝 Commits (1)

  • fc8de2c hotfix: do not return error when getting IconName and IconPixmap but log a warning to the output

📊 Changes

1 file changed (+38 additions, -18 deletions)

View changed files

📝 src/client.rs (+38 -18)

📄 Description

This fix #24 temporarily.

Failed is a generic error in dbus protocol (link), and before this i used to get InvalidArgs when a property does not exist, i'm confused of the error handling here, so i warn it in output and continues to get both property.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/system-tray/pull/25 **Author:** [@ogios](https://github.com/ogios) **Created:** 7/21/2025 **Status:** ✅ Merged **Merged:** 9/14/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`fc8de2c`](https://github.com/JakeStanger/system-tray/commit/fc8de2c0d60e80392dea7f63097bcd6cc2f29a8a) hotfix: do not return error when getting IconName and IconPixmap but log a warning to the output ### 📊 Changes **1 file changed** (+38 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/client.rs` (+38 -18) </details> ### 📄 Description This fix #24 temporarily. `Failed` is a generic error in dbus protocol ([link](https://docs.rs/zbus/latest/zbus/fdo/enum.Error.html#variant.Failed)), and before this i used to get `InvalidArgs` when a property does not exist, i'm confused of the error handling here, so i warn it in output and continues to get both property. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-22 22:04:52 +01:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/system-tray#25
No description provided.