[PR #23] [MERGED] hotfix: Update event take in account of property not exist #24

Closed
opened 2026-05-22 22:04:52 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/system-tray/pull/23
Author: @ogios
Created: 6/27/2025
Status: Merged
Merged: 6/27/2025
Merged by: @JakeStanger

Base: masterHead: hotfix/option-icon-pixel-update


📝 Commits (2)

  • cf2d0b3 fix: take in account of InvalidArgs caused by no property
  • dc5c0ca chore: use clone from for icon pixmap update

📊 Changes

2 files changed (+46 additions, -19 deletions)

View changed files

📝 src/client.rs (+45 -14)
📝 src/data.rs (+1 -5)

📄 Description

I'm sorry, the previous PR gives the ability to update icon pixmap, but i found that sometimes the property is not set thus raises InvalidArgs error.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/system-tray/pull/23 **Author:** [@ogios](https://github.com/ogios) **Created:** 6/27/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `hotfix/option-icon-pixel-update` --- ### 📝 Commits (2) - [`cf2d0b3`](https://github.com/JakeStanger/system-tray/commit/cf2d0b36904cf5fff028f821fbe0c6680761c2f7) fix: take in account of InvalidArgs caused by no property - [`dc5c0ca`](https://github.com/JakeStanger/system-tray/commit/dc5c0caaee3af299e8c45c0cd03260bb58934b55) chore: use clone from for icon pixmap update ### 📊 Changes **2 files changed** (+46 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `src/client.rs` (+45 -14) 📝 `src/data.rs` (+1 -5) </details> ### 📄 Description I'm sorry, the previous PR gives the ability to update icon pixmap, but i found that sometimes the property is not set thus raises InvalidArgs error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-22 22:04:52 +01:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/system-tray#24
No description provided.