JakeStanger/system-tray
1
0
Fork 0
mirror of https://github.com/JakeStanger/system-tray.git synced 2026-07-11 05:15:55 +01:00
Code Issues Projects Releases 9 Packages Wiki Activity Actions

[PR #18] [MERGED] Make Client::items optional #23

New issue
Closed
opened 2026-05-22 22:04:52 +01:00 by JakeStanger · 0 comments
JakeStanger commented 2026-05-22 22:04:52 +01:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/system-tray/pull/18
Author: @ogios
Created: 2/8/2025
Status: ✅ Merged
Merged: 2/28/2025
Merged by: @JakeStanger

Base: master ← Head: data

📝 Commits (7)

📊 Changes

5 files changed (+96 additions, -42 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 Cargo.toml (+3 -1)
📝 src/client.rs (+19 -41)
➕ src/data.rs (+71 -0)
📝 src/lib.rs (+2 -0)

📄 Description

this introduce a feature making items and menus cache optional.
the feature is enable by default.

without the feature, we still preserves the destination of each item, which is for

// Handle other watchers unregistering and this one taking over
// It is necessary to clear all items as our watcher will then re-send them all

though i haven't seen this gets triggered, maybe it's just me over thinking.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/system-tray/pull/18 **Author:** [@ogios](https://github.com/ogios) **Created:** 2/8/2025 **Status:** ✅ Merged **Merged:** 2/28/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `data` --- ### 📝 Commits (7) - [`1e4a798`](https://github.com/JakeStanger/system-tray/commit/1e4a7981d3a773b6dcfaaa0df2be8b82426d27b0) extract data - [`38ff6b3`](https://github.com/JakeStanger/system-tray/commit/38ff6b3da1df0da162c6b9990dcf8201c1d728f5) feature - [`3ddc3a8`](https://github.com/JakeStanger/system-tray/commit/3ddc3a879e2a367712037a3a4eee48e4d876338f) uncomment - [`af7bb13`](https://github.com/JakeStanger/system-tray/commit/af7bb134c96acd68f98a8c7bac6d4c4fcb835d8f) avoid breaking change - [`ddd094e`](https://github.com/JakeStanger/system-tray/commit/ddd094ea7b8d1c0ea0c81bc2d25fa7b879feed69) cfg-if - [`a4a4e36`](https://github.com/JakeStanger/system-tray/commit/a4a4e363eaead40805771dc853f36915890a69db) remove unnecessary clone; please clippy under non-data - [`fe4227d`](https://github.com/JakeStanger/system-tray/commit/fe4227d650be3c6d917d03eb6cb93e50147d624b) less duplicate code ### 📊 Changes **5 files changed** (+96 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `Cargo.toml` (+3 -1) 📝 `src/client.rs` (+19 -41) ➕ `src/data.rs` (+71 -0) 📝 `src/lib.rs` (+2 -0) </details> ### 📄 Description this introduce a feature making items and menus cache optional. the feature is enable by default. without the feature, we still preserves the destination of each item, which is for ``` // Handle other watchers unregistering and this one taking over // It is necessary to clear all items as our watcher will then re-send them all ``` though i haven't seen this gets triggered, maybe it's just me over thinking. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-22 22:04:52 +01:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
fix/layout-update
fix/everythingggggg
v0.8.7
v0.8.6
v0.8.5
v0.8.4
v0.8.3
v0.8.2
v0.8.1
v0.8.0
v0.7.0
v0.6.0
v0.5.0
v0.4.0
v0.3.0
v0.2.0
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/system-tray#23
No description provided.