[PR #1109] [CLOSED] fix: pass the correct GDK Monitor #1153

New issue

Closed

opened 2026-05-22 21:55:44 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 21:55:44 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1109
Author: @da-x
Created: 8/6/2025
Status: ❌ Closed

Base: master ← Head: correct-gdk-monitor

📝 Commits (1)

111d5d5 fix: pass the correct GDK Monitor

📊 Changes

5 files changed (+104 additions, -9 deletions)

View changed files

📝 src/clients/wayland/mod.rs (+1 -1)
📝 src/clients/wayland/wl_output.rs (+2 -0)
➕ src/clients/wayland/wl_output/list.rs (+84 -0)
📝 src/ipc/server/mod.rs (+2 -2)
📝 src/main.rs (+15 -6)

📄 Description

On dual monitor scaling configuration, seems that obtaining the Monitor position using GDK yields the wrong results - both bars end up on the same monitor.

We can use monitor(idx: i32) to obtain the correct one. However the Rust bindings for GdkMonitor are not complete enough to let us call the function that provides the connector name, therefore we need to query smithay to get the vector and from the vector guess the index.

Fixes #1042.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1109 **Author:** [@da-x](https://github.com/da-x) **Created:** 8/6/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `correct-gdk-monitor` --- ### 📝 Commits (1) - [`111d5d5`](https://github.com/JakeStanger/ironbar/commit/111d5d546f310bfd46c410254b3fa031aa8f5115) fix: pass the correct GDK Monitor ### 📊 Changes **5 files changed** (+104 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/clients/wayland/mod.rs` (+1 -1) 📝 `src/clients/wayland/wl_output.rs` (+2 -0) ➕ `src/clients/wayland/wl_output/list.rs` (+84 -0) 📝 `src/ipc/server/mod.rs` (+2 -2) 📝 `src/main.rs` (+15 -6) </details> ### 📄 Description On dual monitor scaling configuration, seems that obtaining the Monitor position using GDK yields the wrong results - both bars end up on the same monitor. We can use `monitor(idx: i32)` to obtain the correct one. However the Rust bindings for GdkMonitor are not complete enough to let us call the function that provides the connector name, therefore we need to query smithay to get the vector and from the vector guess the index. Fixes #1042. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 21:55:44 +01:00