mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 08:15:21 +01:00
[PR #1153] [MERGED] feat(volume): adjust smoothly as slider is dragged #4001
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#4001
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/1153
Author: @JakeStanger
Created: 9/10/2025
Status: ✅ Merged
Merged: 9/10/2025
Merged by: @JakeStanger
Base:
master← Head:feat/smooth-volume📝 Commits (1)
e07d077feat(volume): adjust smoothly as slider is dragged📊 Changes
4 files changed (+113 additions, -72 deletions)
View changed files
📝
src/clients/volume/mod.rs(+53 -10)📝
src/clients/volume/sink.rs(+21 -23)📝
src/clients/volume/sink_input.rs(+20 -22)📝
src/modules/volume.rs(+19 -17)📄 Description
Previously volume was only adjusted when the slider was released, due to an implementation issue where otherwise the server got overwhelmed and Ironbar hard-crashed.
This fixes the issue with the client code to properly support changing volume rapidly, and adjusts the UI code accordingly.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.