[PR #1153] [MERGED] feat(volume): adjust smoothly as slider is dragged #2593

Closed
opened 2026-05-22 22:57:16 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1153
Author: @JakeStanger
Created: 9/10/2025
Status: Merged
Merged: 9/10/2025
Merged by: @JakeStanger

Base: masterHead: feat/smooth-volume


📝 Commits (1)

  • e07d077 feat(volume): adjust smoothly as slider is dragged

📊 Changes

4 files changed (+113 additions, -72 deletions)

View changed files

📝 src/clients/volume/mod.rs (+53 -10)
📝 src/clients/volume/sink.rs (+21 -23)
📝 src/clients/volume/sink_input.rs (+20 -22)
📝 src/modules/volume.rs (+19 -17)

📄 Description

Previously volume was only adjusted when the slider was released, due to an implementation issue where otherwise the server got overwhelmed and Ironbar hard-crashed.

This fixes the issue with the client code to properly support changing volume rapidly, and adjusts the UI code accordingly.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1153 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 9/10/2025 **Status:** ✅ Merged **Merged:** 9/10/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `feat/smooth-volume` --- ### 📝 Commits (1) - [`e07d077`](https://github.com/JakeStanger/ironbar/commit/e07d077c7de716d7e8cc03f954c27780b3e7c41a) feat(volume): adjust smoothly as slider is dragged ### 📊 Changes **4 files changed** (+113 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `src/clients/volume/mod.rs` (+53 -10) 📝 `src/clients/volume/sink.rs` (+21 -23) 📝 `src/clients/volume/sink_input.rs` (+20 -22) 📝 `src/modules/volume.rs` (+19 -17) </details> ### 📄 Description Previously volume was only adjusted when the slider was released, due to an implementation issue where otherwise the server got overwhelmed and Ironbar hard-crashed. This fixes the issue with the client code to properly support changing volume rapidly, and adjusts the UI code accordingly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-22 22:57:16 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#2593
No description provided.