mirror of
https://github.com/JakeStanger/system-tray.git
synced 2026-07-11 05:15:55 +01:00
[PR #22] [MERGED] fix: NewIcon update event send both icon_name and icon_pixmap #22
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/system-tray#22
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/system-tray/pull/22
Author: @ogios
Created: 6/25/2025
Status: ✅ Merged
Merged: 6/25/2025
Merged by: @JakeStanger
Base:
master← Head:icon-update-fix📝 Commits (1)
44c5547fix: NewIcon update event send both icon_name and icon_pixmap📊 Changes
2 files changed (+45 additions, -34 deletions)
View changed files
📝
src/client.rs(+44 -33)📝
src/item.rs(+1 -1)📄 Description
we should have both icon_name and icon_pixmap updated when there's a NewIcon update event.
Video shows dingtalk updating icon_pixmap to simulate blink effect:
https://github.com/user-attachments/assets/e7db86fd-db02-438b-ae1b-ea7048b235ed
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.