mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 08:15:21 +01:00
[PR #913] [MERGED] fix(notifications): gtk4 port #8060
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#8060
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/913
Author: @pinklifeart
Created: 3/27/2025
Status: ✅ Merged
Merged: 3/27/2025
Merged by: @JakeStanger
Base:
refactor/gtk-4← Head:refactor/gtk-4📝 Commits (1)
80be1fefix(notifications): gtk4 port📊 Changes
1 file changed (+2 additions, -2 deletions)
View changed files
📝
src/modules/notifications.rs(+2 -2)📄 Description
Replaced the overlay_pass_through call following the migration notes doc: https://docs.gtk.org/gtk4/migrating-3to4.html#adapt-to-changes-in-gtkoverlay-api
Now it successfully compiles and on the first glance seems to be behaving the same as the gtk3 version, so hopefully a little bit of help towards #112 🤞
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.