mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 07:15:19 +01:00
[GH-ISSUE #282] [Workspaces] Visible workspaces CSS selector #112
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#112
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @malicean on GitHub (Aug 23, 2023).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/282
Is your feature request related to a problem? Please describe.
I'm migrating from Waybar and noticed that there's no CSS selector for visible workspaces. I use two monitors, but since I do all my work on my left monitor, workspaces buttons for my right monitor are never highlighted (active).
Describe the solution you'd like
A CSS selector such as
.workspaces .item.visiblewhich is active for workspace buttons whose workspaces are currently visible, including the active one.Describe alternatives you've considered
After writing the previous section, I noticed that there's
.workspaces .item.inactive(implementation) from #147, but it doesn't do anything. Looking at the call sites, all 3 of them have theinactiveparameter set tofalse, which would explain why. I think this is what the variable is supposed to represent, but there's no documentation aside from the comment in #90. I'll try to get it working for this purpose, but I figured I should post the issue regardless.@malicean commented on GitHub (Aug 24, 2023):
Ah, nevermind, I see that inactive is for favorited workspaces that don't exist.
@malicean commented on GitHub (Aug 24, 2023):
I ended up getting it working, the code's on my fork. I realize discussion before writing is the convention, but this is a big QoL to me. If needed, I can adjust design.
@yavko commented on GitHub (Aug 24, 2023):
yuh
@yavko commented on GitHub (Aug 24, 2023):
If ur trying to get workspaces that exist, but aren't focused you could just use
:is(:not(.focused), :not(.inactive))or something, ofc idk if this works in gtk css, but i hope so@yavko commented on GitHub (Aug 24, 2023):
That's my oopsie sorry,
.inactiveis for fake workspace that dont actually exist, but are in favorites list@malicean commented on GitHub (Aug 24, 2023):
The problem isn't what exists but isn't focused, but what exists and is visible. I have 6-10 allocated to my right monitor (via Hyprland config), the rest to the left. Usually most of 6-10 exist, but only one is visible at a time. My left monitor is where I get work done, so 1-5 is almost always focused, leaving most of 6-10 existing but with no indicator as to which one I'm looking at
@JakeStanger commented on GitHub (Aug 24, 2023):
Agreed this is a good QoL addition & deffo makes sense to add it in. If you're able to open a PR, I'll review/merge when I can :)
I'll also look to get the docs updated in a sec to add that missing
.inactiveselector.