JakeStanger/ironbar

Fork 0

mirror of https://github.com/JakeStanger/ironbar.git synced 2026-07-11 07:15:19 +01:00

[GH-ISSUE #606] Dialog Menus show up in launcher #196

New issue

Closed

opened 2026-05-22 21:51:42 +01:00 by JakeStanger · 11 comments

JakeStanger commented

2026-05-22 21:51:42 +01:00

Owner

Originally created by @ClaireNeveu on GitHub (May 22, 2024).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/606

Describe the bug
Sub-windows in an application (like dialog menus) appear in the launcher when open.

To Reproduce
Steps to reproduce the behavior:

Open VS Code
Right click in the file editor
Observe that a new item appears in the launcher

Expected behavior
The launcher should not display a new item.

System information:

Distro: Arch Linux
Compositor: Hyprland 0.40.0
Ironbar version: 0.16.0-pre

Configuration

Share your bar configuration and stylesheet as applicable:

Config

Styles

Additional context
This might be related to Krita getting stuck in the launcher since it opens a lot of subwindows.

Screenshots

If applicable, add screenshots to help explain your problem.

Originally created by @ClaireNeveu on GitHub (May 22, 2024). Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/606 **Describe the bug** Sub-windows in an application (like dialog menus) appear in the launcher when open. **To Reproduce** Steps to reproduce the behavior: 1. Open VS Code 2. Right click in the file editor 3. Observe that a new item appears in the launcher **Expected behavior** The launcher should not display a new item. **System information:** - Distro: Arch Linux - Compositor: Hyprland 0.40.0 - Ironbar version: 0.16.0-pre **Configuration** > Share your bar configuration and stylesheet as applicable: <details><summary>Config</summary> ``` ``` </details> <details><summary>Styles</summary> ```css ``` </details> **Additional context** This might be related to Krita getting stuck in the launcher since it opens a lot of subwindows. **Screenshots** > If applicable, add screenshots to help explain your problem.

JakeStanger closed this issue

2026-05-22 21:51:42 +01:00

JakeStanger commented

2026-05-22 21:51:43 +01:00

Author

Owner

@ClaireNeveu commented on GitHub (May 22, 2024):

Still working on getting a minimum repro on the Krita issue, it doesn't happen if you close Krita right away but consistently after I've been drawing for an hour or two and close it, ironbar thinks it's still running until I restart ironbar.

@ClaireNeveu commented on GitHub (May 22, 2024): Still working on getting a minimum repro on the Krita issue, it doesn't happen if you close Krita right away but consistently after I've been drawing for an hour or two and close it, ironbar thinks it's still running until I restart ironbar.

JakeStanger commented

2026-05-22 21:51:43 +01:00

Author

Owner

@JakeStanger commented on GitHub (May 22, 2024):

I've got a feeling this is going to be an easy fix, or nigh impossible. Out of interest, do you know whether krita is native or xwayland?

@JakeStanger commented on GitHub (May 22, 2024): I've got a feeling this is going to be an easy fix, or nigh impossible. Out of interest, do you know whether krita is native or xwayland?

JakeStanger commented

2026-05-22 21:51:43 +01:00

Author

Owner

@ClaireNeveu commented on GitHub (May 22, 2024):

Krita is an xwayland app.

@ClaireNeveu commented on GitHub (May 22, 2024): Krita is an xwayland app.

JakeStanger commented

2026-05-22 21:51:43 +01:00

Author

Owner

@JakeStanger commented on GitHub (May 22, 2024):

In theory, I think it should be possible to detect if a window has a parent window using wlr_foreign_toplevel_management, which is already hooked up. This means it should be easy.

As far as I can see though, Hyprland never sends that info, so I need to dig a bit deeper and see if another compositor does and if it'll help.

As an aside, I had krita open to test and hit the same bug where it doesn't close properly. I did open a single dialog. It seems strange I've never seen this occur with anything else. My Jetbrains IDEs are all xwayland and spam child windows like nothing else so I don't think that's the culprit.

@JakeStanger commented on GitHub (May 22, 2024): In theory, I think it should be possible to detect if a window has a parent window using `wlr_foreign_toplevel_management`, which is already hooked up. This means it *should* be easy. As far as I can see though, Hyprland never sends that info, so I need to dig a bit deeper and see if another compositor does and if it'll help. As an aside, I had krita open to test and hit the same bug where it doesn't close properly. I did open a single dialog. It seems strange I've never seen this occur with anything else. My Jetbrains IDEs are all xwayland and spam child windows like nothing else so I don't think that's the culprit.

JakeStanger commented

2026-05-22 21:51:43 +01:00

Author

Owner

@ClaireNeveu commented on GitHub (May 22, 2024):

Hmm, this might be a bug in Hyprland, they just did a big rewrite with 0.40.0.

@ClaireNeveu commented on GitHub (May 22, 2024): Hmm, this might be a bug in Hyprland, they just did a big rewrite with 0.40.0.

JakeStanger commented

2026-05-22 21:51:43 +01:00

Author

Owner

@JakeStanger commented on GitHub (Jun 13, 2024):

...and an even bigger one with 0.41.0. Hyprland isn't particularly stable right now as a result, but I'd be interested to know if you still have the issue after updating.

@JakeStanger commented on GitHub (Jun 13, 2024): ...and an even bigger one with 0.41.0. Hyprland isn't particularly stable right now as a result, but I'd be interested to know if you still have the issue after updating.

JakeStanger commented

2026-05-22 21:51:43 +01:00

Author

Owner

@ClaireNeveu commented on GitHub (Jun 17, 2024):

This does still happen on 0.41.x

@ClaireNeveu commented on GitHub (Jun 17, 2024): This does still happen on 0.41.x

JakeStanger commented

2026-05-22 21:51:43 +01:00

Author

Owner

@ClaireNeveu commented on GitHub (Jun 18, 2024):

0.41.x is even more broken than 0.40.x it seems so take that for what it is.

@ClaireNeveu commented on GitHub (Jun 18, 2024): 0.41.x is even more broken than 0.40.x it seems so take that for what it is.

JakeStanger commented

2026-05-22 21:51:43 +01:00

Author

Owner

@donovanglover commented on GitHub (Jul 15, 2024):

Also occurs with 0.41.2 and hovering over links that have titles in xwayland chromium

@donovanglover commented on GitHub (Jul 15, 2024): Also occurs with 0.41.2 and hovering over links that have titles in xwayland chromium

JakeStanger commented

2026-05-22 21:51:43 +01:00

Author

Owner

@JakeStanger commented on GitHub (Aug 14, 2024):

Still occurs in v0.42.0

I've seen this quite a few times with different apps myself and every time it seems to be xwayland. A little bit of digging seems to show that these are created as xwayland windows with no title/class.

I'm going to try filtering those out and we'll see if that sorts it. At the very least, it should help mitigate it.

@JakeStanger commented on GitHub (Aug 14, 2024): Still occurs in v0.42.0 I've seen this quite a few times with different apps myself and every time it seems to be xwayland. A little bit of digging seems to show that these are created as xwayland windows with no title/class. I'm going to try filtering those out and we'll see if that sorts it. At the very least, it should help mitigate it.

JakeStanger commented

2026-05-22 21:51:43 +01:00

Author

Owner

@JakeStanger commented on GitHub (Aug 14, 2024):

This seems to have caught all the examples I know of, at least. Any further issues let me know and I'll re-open.

@JakeStanger commented on GitHub (Aug 14, 2024): This seems to have caught all the examples I know of, at least. Any further issues let me know and I'll re-open.

JakeStanger referenced this issue

2026-05-22 21:53:50 +01:00

[PR #196] [MERGED] fix(launcher): crash when focusing newly opened window in popup #542

JakeStanger referenced this issue

2026-05-22 22:55:24 +01:00

[PR #196] [MERGED] fix(launcher): crash when focusing newly opened window in popup #1948

JakeStanger referenced this issue

2026-05-22 23:55:33 +01:00

[PR #196] [MERGED] fix(launcher): crash when focusing newly opened window in popup #3357

JakeStanger referenced this issue

2026-05-23 00:55:21 +01:00

[PR #196] [MERGED] fix(launcher): crash when focusing newly opened window in popup #4760