[PR #196] [MERGED] fix(launcher): crash when focusing newly opened window in popup #1948

Closed
opened 2026-05-22 22:55:24 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/196
Author: @JakeStanger
Created: 6/18/2023
Status: Merged
Merged: 6/18/2023
Merged by: @JakeStanger

Base: masterHead: fix/launcher-crash


📝 Commits (1)

  • 103a224 fix(launcher): crash when focusing newly opened window in popup

📊 Changes

1 file changed (+0 additions, -4 deletions)

View changed files

📝 src/modules/launcher/mod.rs (+0 -4)

📄 Description

Attempting to focus a newly opened window from the launcher popup attempted to close the popup directly in an invalid manner, which caused the bar to hard crash. The controller already handles this correctly, so removed this code.

Resolves #41 🎉


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/196 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 6/18/2023 **Status:** ✅ Merged **Merged:** 6/18/2023 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/launcher-crash` --- ### 📝 Commits (1) - [`103a224`](https://github.com/JakeStanger/ironbar/commit/103a224355e8f700904a2b8fbc87cd7be4f64566) fix(launcher): crash when focusing newly opened window in popup ### 📊 Changes **1 file changed** (+0 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/launcher/mod.rs` (+0 -4) </details> ### 📄 Description Attempting to focus a newly opened window from the launcher popup attempted to close the popup directly in an invalid manner, which caused the bar to hard crash. The controller already handles this correctly, so removed this code. Resolves #41 :tada: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-22 22:55:24 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#1948
No description provided.