[PR #45] [MERGED] Improve benchmarking #44

New issue

Closed

opened 2026-05-22 22:05:17 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 22:05:17 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/corn-config/corn/pull/45
Author: @puppymati
Created: 7/30/2025
Status: ✅ Merged
Merged: 7/31/2025
Merged by: @JakeStanger

Base: master ← Head: feat/new-bench

📝 Commits (1)

dabadd9 Improve benchmarking infrastructure

📊 Changes

1 file changed (+54 additions, -92 deletions)

View changed files

📝 benches/serde.rs (+54 -92)

📄 Description

This PR improves and cleans up the benchmarking code in the following ways:

Removed outdated JSON benchmarks that provided no value or useful comparisons. A proper comparative benchmark can be added later
Organized all benchmarks into a single group without separate benchmarking functions
Proper usage of parameterization and black boxes for cleaner code structure
Replaced deprecated criterion black box with the std one
Added throughput measurement for additional metrics
Removed the deprecated paste macro

The benchmarks themselves remain unchanged. Only the code organization has been improved for better maintainability and consistency.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/corn-config/corn/pull/45 **Author:** [@puppymati](https://github.com/puppymati) **Created:** 7/30/2025 **Status:** ✅ Merged **Merged:** 7/31/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `feat/new-bench` --- ### 📝 Commits (1) - [`dabadd9`](https://github.com/corn-config/corn/commit/dabadd944fc40988fb92e0eaf606f9ddff9ad1a9) Improve benchmarking infrastructure ### 📊 Changes **1 file changed** (+54 additions, -92 deletions) <details> <summary>View changed files</summary> 📝 `benches/serde.rs` (+54 -92) </details> ### 📄 Description This PR improves and cleans up the benchmarking code in the following ways: - Removed outdated JSON benchmarks that provided no value or useful comparisons. A proper comparative benchmark can be added later - Organized all benchmarks into a single group without separate benchmarking functions - Proper usage of parameterization and black boxes for cleaner code structure - Replaced deprecated criterion black box with the std one - Added throughput measurement for additional metrics - Removed the deprecated paste macro The benchmarks themselves remain unchanged. Only the code organization has been improved for better maintainability and consistency. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 22:05:17 +01:00