[PR #40] [MERGED] Restructure codebase to follow modern Rust practices #41

New issue

Closed

opened 2026-05-22 22:05:17 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 22:05:17 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/corn-config/corn/pull/40
Author: @puppymati
Created: 3/5/2025
Status: ✅ Merged
Merged: 3/5/2025
Merged by: @JakeStanger

Base: master ← Head: new-org

📝 Commits (4)

68e329d Completely re-organize workspace
9a95fdc Apply doc suggestions
a144546 Fix wasm-pack on ci
6e43588 Fix lua features

📊 Changes

24 files changed (+315 additions, -174 deletions)

View changed files

📝 .github/workflows/ci.yml (+2 -3)
📝 CHANGELOG.md (+143 -41)
📝 Cargo.lock (+0 -1)
📝 Cargo.toml (+86 -2)
📝 README.md (+7 -6)
📝 benches/serde.rs (+2 -2)
➕ cli/Cargo.toml (+25 -0)
➕ cli/README.md (+8 -0)
📝 cli/src/error.rs (+0 -0)
📝 cli/src/main.rs (+4 -3)
➖ corn-cli/Cargo.toml (+0 -19)
➖ corn-cli/README.md (+0 -5)
➖ corn-cli/src/lib.rs (+0 -1)
➖ libcorn/Cargo.toml (+0 -61)
➖ libcorn/README.md (+0 -5)
📝 src/de.rs (+0 -0)
📝 src/error.rs (+0 -0)
📝 src/grammar.pest (+0 -0)
📝 src/lib.rs (+0 -0)
📝 src/lua.rs (+0 -0)

...and 4 more files

📄 Description

While this appears to be a large PR, it's primarily focused on reorganizing the codebase structure to follow modern Rust practices and establish a solid foundation for future development.

Key changes:

Moved libcorn to the top level directory
Relocated CLI to dedicated cli folder (no extra lib.rs needed)
Updated tests and CI configuration to work with the new structure
Added release profile with proper optimizations
Updated bench configurations to require appropriate features
Refined feature declarations to use proper dependency syntax
Cleaned up and formatted files

Note: It'd recommend to pull this PR locally for review as GitHub's diff view may not clearly represent the structural changes.

Depends on #39

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/corn-config/corn/pull/40 **Author:** [@puppymati](https://github.com/puppymati) **Created:** 3/5/2025 **Status:** ✅ Merged **Merged:** 3/5/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `new-org` --- ### 📝 Commits (4) - [`68e329d`](https://github.com/corn-config/corn/commit/68e329d440cffb5d3da4c5bae2ff6d389a0b6b94) Completely re-organize workspace - [`9a95fdc`](https://github.com/corn-config/corn/commit/9a95fdc0b72178354f5f2691e4ba88177ed62d8d) Apply doc suggestions - [`a144546`](https://github.com/corn-config/corn/commit/a144546e80ae99c124ff9a9caf00660381965524) Fix wasm-pack on ci - [`6e43588`](https://github.com/corn-config/corn/commit/6e4358819f41447b1f9d3251b4b6379fbab09838) Fix lua features ### 📊 Changes **24 files changed** (+315 additions, -174 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+2 -3) 📝 `CHANGELOG.md` (+143 -41) 📝 `Cargo.lock` (+0 -1) 📝 `Cargo.toml` (+86 -2) 📝 `README.md` (+7 -6) 📝 `benches/serde.rs` (+2 -2) ➕ `cli/Cargo.toml` (+25 -0) ➕ `cli/README.md` (+8 -0) 📝 `cli/src/error.rs` (+0 -0) 📝 `cli/src/main.rs` (+4 -3) ➖ `corn-cli/Cargo.toml` (+0 -19) ➖ `corn-cli/README.md` (+0 -5) ➖ `corn-cli/src/lib.rs` (+0 -1) ➖ `libcorn/Cargo.toml` (+0 -61) ➖ `libcorn/README.md` (+0 -5) 📝 `src/de.rs` (+0 -0) 📝 `src/error.rs` (+0 -0) 📝 `src/grammar.pest` (+0 -0) 📝 `src/lib.rs` (+0 -0) 📝 `src/lua.rs` (+0 -0) _...and 4 more files_ </details> ### 📄 Description While this appears to be a large PR, it's primarily focused on reorganizing the codebase structure to follow modern Rust practices and establish a solid foundation for future development. Key changes: - Moved libcorn to the top level directory - Relocated CLI to dedicated cli folder (no extra lib.rs needed) - Updated tests and CI configuration to work with the new structure - Added release profile with proper optimizations - Updated bench configurations to require appropriate features - Refined feature declarations to use proper dependency syntax - Cleaned up and formatted files Note: It'd recommend to pull this PR locally for review as GitHub's diff view may not clearly represent the structural changes. Depends on #39 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger added the

pull-request

label

2026-05-22 22:05:17 +01:00

JakeStanger referenced this issue

2026-05-22 22:05:17 +01:00

[PR #41] Big rewrite of the parser #42

JakeStanger closed this issue

2026-05-22 22:05:17 +01:00