[GH-ISSUE #20] TrayMenu properties in items map aren't updated on MenuDiff event #8

New issue

Closed

opened 2026-05-22 22:04:47 +01:00 by JakeStanger · 1 comment

JakeStanger commented

2026-05-22 22:04:47 +01:00

Owner

Originally created by @Levizor on GitHub (Feb 23, 2025).
Original GitHub issue: https://github.com/JakeStanger/system-tray/issues/20

When we receive MenuDiff update, the differences that it provides are not applied to the state of the corresponding value in items map. TrayMenu properties don't change at this update and hold outdated information.

Seemingly items aren't edited for this specific Update variant, while they're updated with LayoutUpdatedStream in Client::watch_menu .

But in some cases only properties of menu change, which doesn't trigger this layout update. (Found with telegram Enable/Disable notifications toggle button).

Originally created by @Levizor on GitHub (Feb 23, 2025). Original GitHub issue: https://github.com/JakeStanger/system-tray/issues/20 When we receive MenuDiff update, the differences that it provides are not applied to the state of the corresponding value in items map. TrayMenu properties don't change at this update and hold outdated information. Seemingly items aren't edited for this specific Update variant, while they're updated with LayoutUpdatedStream in ```Client::watch_menu ```. But in some cases only properties of menu change, which doesn't trigger this layout update. (Found with telegram Enable/Disable notifications toggle button).

JakeStanger closed this issue

2026-05-22 22:04:47 +01:00

JakeStanger commented

2026-05-22 22:04:47 +01:00

Author

Owner

@Levizor commented on GitHub (Feb 26, 2025):

Now I also notices that watch_item_properties also doesn't have any impact on items, so items map is again not up to date.

@Levizor commented on GitHub (Feb 26, 2025): Now I also notices that ```watch_item_properties``` also doesn't have any impact on items, so items map is again not up to date.

JakeStanger referenced this issue

2026-05-22 22:04:51 +01:00

[PR #12] [MERGED] Add aboutToShow in client #16

JakeStanger referenced this issue

2026-05-22 22:59:58 +01:00

[GH-ISSUE #8] we shoule be exposing DBusMenu aboutToShow #2