[GH-ISSUE #9] Maybe we can start using zvarient like cosmic does? #4

New issue

Closed

opened 2026-05-22 22:04:46 +01:00 by JakeStanger · 3 comments

JakeStanger commented

2026-05-22 22:04:46 +01:00

Owner

Originally created by @ogios on GitHub (Jan 31, 2025).
Original GitHub issue: https://github.com/JakeStanger/system-tray/issues/9

Like this(from cosmic):

#[derive(Clone, Debug, zvariant::DeserializeDict)]
pub struct LayoutProps {
    #[zvariant(rename = "accessible-desc")]
    accessible_desc: Option<String>,
    #[zvariant(rename = "children-display")]
    children_display: Option<String>,
    label: Option<String>,
    enabled: Option<bool>,
    visible: Option<bool>,
    #[zvariant(rename = "type")]
    type_: Option<String>,
    #[zvariant(rename = "toggle-type")]
    toggle_type: Option<String>,
    #[zvariant(rename = "toggle-state")]
    toggle_state: Option<i32>,
    #[zvariant(rename = "icon-data")]
    icon_data: Option<Vec<u8>>,
    #[zvariant(rename = "icon-name")]
    icon_name: Option<String>,
    disposition: Option<String>,
    // If this field has a different type, this causes the whole type to fail
    // to parse, due to a zvariant bug.
    // https://github.com/dbus2/zbus/issues/856
    // shortcut: Option<String>,
}

impl zvariant::Type for LayoutProps {
    fn signature() -> zvariant::Signature<'static> {
        zvariant::Signature::try_from("a{sv}").unwrap()
    }
}

Originally created by @ogios on GitHub (Jan 31, 2025). Original GitHub issue: https://github.com/JakeStanger/system-tray/issues/9 Like this(from cosmic): ```rust #[derive(Clone, Debug, zvariant::DeserializeDict)] pub struct LayoutProps { #[zvariant(rename = "accessible-desc")] accessible_desc: Option<String>, #[zvariant(rename = "children-display")] children_display: Option<String>, label: Option<String>, enabled: Option<bool>, visible: Option<bool>, #[zvariant(rename = "type")] type_: Option<String>, #[zvariant(rename = "toggle-type")] toggle_type: Option<String>, #[zvariant(rename = "toggle-state")] toggle_state: Option<i32>, #[zvariant(rename = "icon-data")] icon_data: Option<Vec<u8>>, #[zvariant(rename = "icon-name")] icon_name: Option<String>, disposition: Option<String>, // If this field has a different type, this causes the whole type to fail // to parse, due to a zvariant bug. // https://github.com/dbus2/zbus/issues/856 // shortcut: Option<String>, } impl zvariant::Type for LayoutProps { fn signature() -> zvariant::Signature<'static> { zvariant::Signature::try_from("a{sv}").unwrap() } } ```

JakeStanger closed this issue

2026-05-22 22:04:46 +01:00

JakeStanger commented

2026-05-22 22:04:46 +01:00

Author

Owner

@JakeStanger commented on GitHub (Jan 31, 2025):

I'm struggling to understand this. What are the advantages of going this route?

@JakeStanger commented on GitHub (Jan 31, 2025): I'm struggling to understand this. What are the advantages of going this route?

JakeStanger commented

2026-05-22 22:04:47 +01:00

Author

Owner

@ogios commented on GitHub (Jan 31, 2025):

i just thinks it may introduce less code for us to maintain.
we're fine with what we do currently, this is not necessary

@ogios commented on GitHub (Jan 31, 2025): i just thinks it may introduce less code for us to maintain. we're fine with what we do currently, this is not necessary

JakeStanger commented

2026-05-22 22:04:47 +01:00

Author

Owner

@JakeStanger commented on GitHub (Jan 31, 2025):

i just thinks it may introduce less code for us to maintain.

Always a plus in my books - if you're happy to take it on, go for it. I won't be able to take it on any time soon unfortunately though.

@JakeStanger commented on GitHub (Jan 31, 2025): > i just thinks it may introduce less code for us to maintain. Always a plus in my books - if you're happy to take it on, go for it. I won't be able to take it on any time soon unfortunately though.

JakeStanger referenced this issue

2026-05-22 22:04:49 +01:00

[PR #4] [MERGED] Add tokio feature for zbus; Add basic example as example/basic.rs #11