[PR #14] [MERGED] Upgrade to zbus5 #19

New issue

Closed

opened 2026-05-22 22:04:51 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 22:04:51 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/system-tray/pull/14
Author: @ogios
Created: 1/31/2025
Status: ✅ Merged
Merged: 2/8/2025
Merged by: @JakeStanger

Base: master ← Head: upstream

📝 Commits (10+)

b3e498e api update
2e730f4 Merge branch 'master' into upstream
d829402 result wrapper for dbusmenu
f966070 update ownedvalueext
6d8578f item error unify
c257840 all wrapped with ok
ea510d6 remove ref for some basic type
265b7c1 item
cc1b474 fix clippy
6f3050c get_update_event return Result

📊 Changes

10 files changed (+489 additions, -1063 deletions)

View changed files

📝 Cargo.lock (+240 -831)
📝 Cargo.toml (+7 -7)
📝 src/client.rs (+34 -34)
📝 src/dbus/dbus_menu_proxy.rs (+8 -8)
📝 src/dbus/mod.rs (+16 -9)
📝 src/dbus/notifier_item_proxy.rs (+24 -24)
📝 src/dbus/notifier_watcher_proxy.rs (+10 -10)
📝 src/dbus/status_notifier_watcher.rs (+57 -45)
📝 src/item.rs (+61 -57)
📝 src/menu.rs (+32 -38)

📄 Description

the main thing is downcast_ref for zvariant now returns Result, so lots of .ok()

Resolves #13

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/system-tray/pull/14 **Author:** [@ogios](https://github.com/ogios) **Created:** 1/31/2025 **Status:** ✅ Merged **Merged:** 2/8/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `upstream` --- ### 📝 Commits (10+) - [`b3e498e`](https://github.com/JakeStanger/system-tray/commit/b3e498e7ea54a69ff57acda54fa85a3877ae2145) api update - [`2e730f4`](https://github.com/JakeStanger/system-tray/commit/2e730f460e4744213e8622315d7fcd71d84d1e69) Merge branch 'master' into upstream - [`d829402`](https://github.com/JakeStanger/system-tray/commit/d82940274cd20ec69e7ad0517512a0a9451d9d45) result wrapper for dbusmenu - [`f966070`](https://github.com/JakeStanger/system-tray/commit/f966070b3e11ba18728435cacd9b1cc926eb8a92) update ownedvalueext - [`6d8578f`](https://github.com/JakeStanger/system-tray/commit/6d8578f13da2750f37cc7f93419eb90b36d2aeae) item error unify - [`c257840`](https://github.com/JakeStanger/system-tray/commit/c257840dbf77f130b548668d1ed6801fe5e087a3) all wrapped with ok - [`ea510d6`](https://github.com/JakeStanger/system-tray/commit/ea510d64e572a1038075f5f3b5711cee7c7a1279) remove ref for some basic type - [`265b7c1`](https://github.com/JakeStanger/system-tray/commit/265b7c1c6c5bbde4b41c0c2c7e549765a0d922d0) item - [`cc1b474`](https://github.com/JakeStanger/system-tray/commit/cc1b474a56ceed2be5b4f9a0c06ee6d11ef75211) fix clippy - [`6f3050c`](https://github.com/JakeStanger/system-tray/commit/6f3050cfd677735c31734ba52f1d5835a12b0958) get_update_event return Result ### 📊 Changes **10 files changed** (+489 additions, -1063 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+240 -831) 📝 `Cargo.toml` (+7 -7) 📝 `src/client.rs` (+34 -34) 📝 `src/dbus/dbus_menu_proxy.rs` (+8 -8) 📝 `src/dbus/mod.rs` (+16 -9) 📝 `src/dbus/notifier_item_proxy.rs` (+24 -24) 📝 `src/dbus/notifier_watcher_proxy.rs` (+10 -10) 📝 `src/dbus/status_notifier_watcher.rs` (+57 -45) 📝 `src/item.rs` (+61 -57) 📝 `src/menu.rs` (+32 -38) </details> ### 📄 Description the main thing is downcast_ref for zvariant now returns Result, so lots of `.ok()` Resolves #13 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 22:04:51 +01:00