[PR #2] [MERGED] The everything fixes #12

New issue

Closed

opened 2026-05-22 22:04:49 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 22:04:49 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/system-tray/pull/2
Author: @JakeStanger
Created: 11/4/2024
Status: ✅ Merged
Merged: 11/8/2024
Merged by: @JakeStanger

Base: master ← Head: fix/everythingggggg

📝 Commits (10+)

6e9da48 fix: apply patch of code taken from eww
0347fdc chore: first round of tidying to patch
2aac772 fix: icons duplicating when another host shuts down
a024686 test(client): add basic tests for address parsing
113a2f5 chore: update dead link
ad3af80 fix: not mapping icon data
147221f chore(intellij): add git toolbox blame
a79e9bc fix: calling missing unregister_status_notifier_item method
290deb0 fix: property updates were broken
1031918 refactor: general code quality improvements

📊 Changes

16 files changed (+713 additions, -212 deletions)

View changed files

➕ .github/workflows/build.yml (+55 -0)
➕ .github/workflows/deploy.yml (+56 -0)
➕ .idea/git_toolbox_blame.xml (+6 -0)
📝 Cargo.lock (+20 -20)
📝 Cargo.toml (+4 -1)
📝 README.md (+2 -2)
📝 src/client.rs (+147 -35)
📝 src/dbus/dbus_menu_proxy.rs (+2 -2)
📝 src/dbus/mod.rs (+6 -7)
📝 src/dbus/notifier_item_proxy.rs (+2 -2)
📝 src/dbus/notifier_watcher_proxy.rs (+3 -2)
📝 src/dbus/status_notifier_watcher.rs (+292 -90)
📝 src/error.rs (+2 -0)
📝 src/item.rs (+54 -34)
📝 src/lib.rs (+32 -2)
📝 src/menu.rs (+30 -15)

📄 Description

Fixes #1

Also fixes a whoooole load of issues with the tray. Combined with some changes in Ironbar, hopefully all of the below:

https://github.com/JakeStanger/ironbar/issues/640
https://github.com/JakeStanger/ironbar/issues/645
https://github.com/JakeStanger/ironbar/issues/672
https://github.com/JakeStanger/ironbar/issues/714
https://github.com/JakeStanger/ironbar/issues/647
https://github.com/JakeStanger/ironbar/issues/632
https://github.com/JakeStanger/ironbar/issues/751

Huge thanks to @ToxicMushroom for your help porting over the host code & other fixes from eww (and huge thanks to @elkowar for writing it in the first place ❤️). That did a lot of the heavy lifting here, and I've only had really had to tidy up and fix the edge cases.

🎉 🎉 🎉

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/system-tray/pull/2 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/8/2024 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/everythingggggg` --- ### 📝 Commits (10+) - [`6e9da48`](https://github.com/JakeStanger/system-tray/commit/6e9da48c0905a243451f05b5268f0c6aba66b882) fix: apply patch of code taken from eww - [`0347fdc`](https://github.com/JakeStanger/system-tray/commit/0347fdc1ae9f250f77c5ff78949ccfbedf6e889a) chore: first round of tidying to patch - [`2aac772`](https://github.com/JakeStanger/system-tray/commit/2aac7724f67bdf68d8c3b624982a4fa69ab36f6b) fix: icons duplicating when another host shuts down - [`a024686`](https://github.com/JakeStanger/system-tray/commit/a024686321cbc32609cc60ead48f68a4f8fb9ed2) test(client): add basic tests for address parsing - [`113a2f5`](https://github.com/JakeStanger/system-tray/commit/113a2f53b9679c8dccd07e256ff0a7d8ae871f89) chore: update dead link - [`ad3af80`](https://github.com/JakeStanger/system-tray/commit/ad3af8025bdf8839c86e7674fc92539956b1f38f) fix: not mapping icon data - [`147221f`](https://github.com/JakeStanger/system-tray/commit/147221f6f88039bf3cc812e9e3323271d5b87117) chore(intellij): add git toolbox blame - [`a79e9bc`](https://github.com/JakeStanger/system-tray/commit/a79e9bca7099028e1ca6857df45c6def05c28d6d) fix: calling missing `unregister_status_notifier_item` method - [`290deb0`](https://github.com/JakeStanger/system-tray/commit/290deb0cc2ab5a50e307d5f83d73baa5662f68a2) fix: property updates were broken - [`1031918`](https://github.com/JakeStanger/system-tray/commit/1031918e124c70945a6697ee7d66a0a468d494b9) refactor: general code quality improvements ### 📊 Changes **16 files changed** (+713 additions, -212 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/build.yml` (+55 -0) ➕ `.github/workflows/deploy.yml` (+56 -0) ➕ `.idea/git_toolbox_blame.xml` (+6 -0) 📝 `Cargo.lock` (+20 -20) 📝 `Cargo.toml` (+4 -1) 📝 `README.md` (+2 -2) 📝 `src/client.rs` (+147 -35) 📝 `src/dbus/dbus_menu_proxy.rs` (+2 -2) 📝 `src/dbus/mod.rs` (+6 -7) 📝 `src/dbus/notifier_item_proxy.rs` (+2 -2) 📝 `src/dbus/notifier_watcher_proxy.rs` (+3 -2) 📝 `src/dbus/status_notifier_watcher.rs` (+292 -90) 📝 `src/error.rs` (+2 -0) 📝 `src/item.rs` (+54 -34) 📝 `src/lib.rs` (+32 -2) 📝 `src/menu.rs` (+30 -15) </details> ### 📄 Description Fixes #1 Also fixes a whoooole load of issues with the tray. Combined with some changes in Ironbar, hopefully all of the below: https://github.com/JakeStanger/ironbar/issues/640 https://github.com/JakeStanger/ironbar/issues/645 https://github.com/JakeStanger/ironbar/issues/672 https://github.com/JakeStanger/ironbar/issues/714 https://github.com/JakeStanger/ironbar/issues/647 https://github.com/JakeStanger/ironbar/issues/632 https://github.com/JakeStanger/ironbar/issues/751 Huge thanks to @ToxicMushroom for your help porting over the host code & other fixes from eww (and huge thanks to @elkowar for writing it in the first place :heart:). That did a *lot* of the heavy lifting here, and I've only had really had to tidy up and fix the edge cases. :tada: :tada: :tada: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 22:04:49 +01:00