JakeStanger/mpd-discord-rpc
1
0
Fork 0
mirror of https://github.com/JakeStanger/mpd-discord-rpc.git synced 2026-07-11 09:15:30 +01:00
Code Issues 28 Projects Releases 10 Packages Wiki Activity Actions

[PR #223] [CLOSED] fix: stop calling DiscordClient::start() when error is thrown #231

New issue
Closed
opened 2026-05-22 22:04:22 +01:00 by JakeStanger · 0 comments
JakeStanger commented 2026-05-22 22:04:22 +01:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/mpd-discord-rpc/pull/223
Author: @Elvyria
Created: 8/12/2025
Status: ❌ Closed

Base: master ← Head: fix/thread-leak

📝 Commits (1)

  • 52d3525 fix: stop calling DiscordClient::start() when error is thrown

📊 Changes

1 file changed (+1 additions, -6 deletions)

View changed files

📝 src/main.rs (+1 -6)

📄 Description

Closes: https://github.com/JakeStanger/mpd-discord-rpc/issues/204

DiscordClient::start() will attempt to reconnect automatically, calling it manually is allowed for some reason and spawns additional threads.

Tested briefly - closed and opened Discord client around 5 times while running, reconnects automatically, no issues, additional threads are no longer spawned.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/mpd-discord-rpc/pull/223 **Author:** [@Elvyria](https://github.com/Elvyria) **Created:** 8/12/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/thread-leak` --- ### 📝 Commits (1) - [`52d3525`](https://github.com/JakeStanger/mpd-discord-rpc/commit/52d352560059e836520a8da7108dfbbbfa6447da) fix: stop calling `DiscordClient::start()` when error is thrown ### 📊 Changes **1 file changed** (+1 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/main.rs` (+1 -6) </details> ### 📄 Description Closes: https://github.com/JakeStanger/mpd-discord-rpc/issues/204 DiscordClient::start() will attempt to reconnect automatically, calling it manually is allowed for some reason and spawns additional threads. Tested briefly - closed and opened Discord client around 5 times while running, reconnects automatically, no issues, additional threads are no longer spawned. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-22 22:04:22 +01:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/cargo/reqwest-0.13.2
dependabot/cargo/regex-1.12.3
feat/listening-activity
fix/max-length
fix/unix-socket-host
v1.11.0
v1.10.0
v1.9.0
v1.8.1
v1.8.0
v1.7.3
v1.7.2
v1.7.1
v1.7.0
v1.6.0
v1.5.4b
v1.5.4
v1.5.3
v0.5.3
v1.5.2
v1.5.1
v1.5.0
v1.4.1
v1.4.0
v1.3.0
v1.2.3
v1.2.0
v1.1.3
v1.1.2
v1.0.2
Labels
Clear labels   
bug

   
enhancement

   
help wanted

   
package

   
pull-request
Mirrored from GitHub Pull Request

  
wontfix
No labels
bug
enhancement
help wanted
package
pull-request
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/mpd-discord-rpc#231
No description provided.