[PR #16] [MERGED] Cargo: replace -> patch #1653

New issue

Closed

opened 2026-05-23 03:58:23 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 03:58:23 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/mpd-discord-rpc/pull/16
Author: @Kranzes
Created: 2/17/2022
Status: ✅ Merged
Merged: 2/17/2022
Merged by: @JakeStanger

Base: master ← Head: master

📝 Commits (1)

0217e43 Cargo: replace -> patch

📊 Changes

2 files changed (+45 additions, -43 deletions)

View changed files

📝 Cargo.lock (+43 -41)
📝 Cargo.toml (+2 -2)

📄 Description

According to the Cargo docs, [replace] is now deprecated and [patch] should be used instead.
This should also fix the issue when creating a Nix expression for the package.
Can you also tag a new github release after so the package can be added nicely into nixpkgs?

Edit: Nix expression works accordingly with the changes of this PR. https://gist.github.com/Kranzes/77f700dce3f4108233901917b1763ae5

Edit 2: I have also created a configurable home-manager module which I will upstream once this gets merged. (and on nixpkgs)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/mpd-discord-rpc/pull/16 **Author:** [@Kranzes](https://github.com/Kranzes) **Created:** 2/17/2022 **Status:** ✅ Merged **Merged:** 2/17/2022 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`0217e43`](https://github.com/JakeStanger/mpd-discord-rpc/commit/0217e434d7a3842912599bc57745ec9d99457314) Cargo: replace -> patch ### 📊 Changes **2 files changed** (+45 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+43 -41) 📝 `Cargo.toml` (+2 -2) </details> ### 📄 Description According to the [Cargo docs](https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-replace-section), `[replace]` is now deprecated and `[patch]` should be used instead. This should also fix the issue when creating a Nix expression for the package. Can you also tag a new github release after so the package can be added nicely into [nixpkgs](https://github.com/NixOS/nixpkgs)? Edit: Nix expression works accordingly with the changes of this PR. https://gist.github.com/Kranzes/77f700dce3f4108233901917b1763ae5 Edit 2: I have also created a configurable [home-manager](https://github.com/nix-community/home-manager/pull/2728) module which I will upstream once this gets merged. (and on nixpkgs) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 03:58:23 +01:00