[PR #225] [MERGED] fix: create drpc client with error config #1567

New issue

Closed

opened 2026-05-23 02:58:41 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 02:58:41 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/mpd-discord-rpc/pull/225
Author: @koffydrop
Created: 8/19/2025
Status: ✅ Merged
Merged: 8/21/2025
Merged by: @JakeStanger

Base: master ← Head: master

📝 Commits (2)

7592cde chore: fix inconsistent indentation inside tokio::select!
a82faf0 fix: create drpc client with error config

📊 Changes

1 file changed (+12 additions, -11 deletions)

View changed files

📝 src/main.rs (+12 -11)

📄 Description

Fixes https://github.com/JakeStanger/mpd-discord-rpc/issues/204

Creating the drpc client with DiscordClient::with_error_config() and 0 attempts makes the spawned threads actually exit on error and not persist to keep retrying.

Tested a few cases where I observed the issue, starting with discord opened, closed, before and after the socket is created, no extra threads persist and connection is consistent.
Will continue using as my main service to check if behavior changes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/mpd-discord-rpc/pull/225 **Author:** [@koffydrop](https://github.com/koffydrop) **Created:** 8/19/2025 **Status:** ✅ Merged **Merged:** 8/21/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`7592cde`](https://github.com/JakeStanger/mpd-discord-rpc/commit/7592cdef2b78c833b174f862d8a35dd16d532798) chore: fix inconsistent indentation inside `tokio::select!` - [`a82faf0`](https://github.com/JakeStanger/mpd-discord-rpc/commit/a82faf0f12109536b78016ff3faace46b370929a) fix: create drpc client with error config ### 📊 Changes **1 file changed** (+12 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/main.rs` (+12 -11) </details> ### 📄 Description Fixes https://github.com/JakeStanger/mpd-discord-rpc/issues/204 Creating the drpc client with `DiscordClient::with_error_config()` and 0 attempts makes the spawned threads actually exit on error and not persist to keep retrying. Tested a few cases where I observed the issue, starting with discord opened, closed, before and after the socket is created, no extra threads persist and connection is consistent. Will continue using as my main service to check if behavior changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 02:58:41 +01:00