[PR #1233] [MERGED] feat: rework networkmanager module #9670

New issue

Closed

opened 2026-05-23 03:57:14 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 03:57:14 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1233
Author: @Rodrigodd
Created: 11/4/2025
Status: ✅ Merged
Merged: 2/12/2026
Merged by: @JakeStanger

Base: master ← Head: feat-network-manager-rework

📝 Commits (10+)

7dcab7f feat: reword networkmanager module
7f98553 refactor: rename 'IconsConfig' to 'Icons'
1a1a0b4 refactor: update DeviceType documentation
ea0a868 refactor: replace mutually exclusive bools with enum
67fb79a refactor: move module_impl! to top of impl
c7a6c71 docs(network-manager): update docs
6fc6eb9 fix(networkmanager): fix panic when number of wifi levels is 0 or 1
80132ff refactor: simplify use of #[serder(default)]
64c7483 docs: fix typo
efece1b style: move comments of unmapped dbus properties

📊 Changes

10 files changed (+1379 additions, -316 deletions)

View changed files

📝 Cargo.lock (+0 -35)
📝 Cargo.toml (+1 -4)
📝 docs/modules/Network-Manager.md (+169 -52)
➖ src/clients/networkmanager.rs (+0 -170)
➕ src/clients/networkmanager/dbus.rs (+249 -0)
➕ src/clients/networkmanager/mod.rs (+459 -0)
➕ src/clients/networkmanager/state.rs (+128 -0)
📝 src/modules/networkmanager.rs (+173 -55)
➕ src/modules/networkmanager/config.rs (+177 -0)
➕ test-configs/network-manager.corn (+23 -0)

📄 Description

Allow a dynamic number of devices.
Show WiFi connection strength and update in real time.
Allow configuring the icons.
Show network info as tool-tip.
Allow whitelist/blacklisting device names/types.

I only have a WiFi and Wireguard interfaces, so I was unable to test other device types, but I tried to preserve the existing functionality as much as I could.

Screenshot

#148

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1233 **Author:** [@Rodrigodd](https://github.com/Rodrigodd) **Created:** 11/4/2025 **Status:** ✅ Merged **Merged:** 2/12/2026 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `feat-network-manager-rework` --- ### 📝 Commits (10+) - [`7dcab7f`](https://github.com/JakeStanger/ironbar/commit/7dcab7f2f93289d11bec65e1169fe2208793cfa8) feat: reword networkmanager module - [`7f98553`](https://github.com/JakeStanger/ironbar/commit/7f9855346116590f3e4c53e02db4c71d07a75027) refactor: rename 'IconsConfig' to 'Icons' - [`1a1a0b4`](https://github.com/JakeStanger/ironbar/commit/1a1a0b4b03f8b5fd001642d3030e5de4a22fa0ab) refactor: update DeviceType documentation - [`ea0a868`](https://github.com/JakeStanger/ironbar/commit/ea0a868f2f91c05282d159394acf11c203bfa7ea) refactor: replace mutually exclusive bools with enum - [`67fb79a`](https://github.com/JakeStanger/ironbar/commit/67fb79a9bd8e975f52bf22e6295acd876bfd2636) refactor: move module_impl! to top of impl - [`c7a6c71`](https://github.com/JakeStanger/ironbar/commit/c7a6c71d01de7c6beb5ec406f0448ba27fc56b13) docs(network-manager): update docs - [`6fc6eb9`](https://github.com/JakeStanger/ironbar/commit/6fc6eb9d74ccb838562f14666eb4b3f5abaf8f72) fix(networkmanager): fix panic when number of wifi levels is 0 or 1 - [`80132ff`](https://github.com/JakeStanger/ironbar/commit/80132ff43f08562090430e94ec025e21a3e5b382) refactor: simplify use of `#[serder(default)]` - [`64c7483`](https://github.com/JakeStanger/ironbar/commit/64c7483a56e9b4fd0b6bc6cd88845156f0f5ba7b) docs: fix typo - [`efece1b`](https://github.com/JakeStanger/ironbar/commit/efece1b58aaf0eaa31fedadfb450a149364e257a) style: move comments of unmapped dbus properties ### 📊 Changes **10 files changed** (+1379 additions, -316 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+0 -35) 📝 `Cargo.toml` (+1 -4) 📝 `docs/modules/Network-Manager.md` (+169 -52) ➖ `src/clients/networkmanager.rs` (+0 -170) ➕ `src/clients/networkmanager/dbus.rs` (+249 -0) ➕ `src/clients/networkmanager/mod.rs` (+459 -0) ➕ `src/clients/networkmanager/state.rs` (+128 -0) 📝 `src/modules/networkmanager.rs` (+173 -55) ➕ `src/modules/networkmanager/config.rs` (+177 -0) ➕ `test-configs/network-manager.corn` (+23 -0) </details> ### 📄 Description - Allow a dynamic number of devices. - Show WiFi connection strength and update in real time. - Allow configuring the icons. - Show network info as tool-tip. - Allow whitelist/blacklisting device names/types. I only have a WiFi and Wireguard interfaces, so I was unable to test other device types, but I tried to preserve the existing functionality as much as I could. ### Screenshot <img width="1920" height="1080" alt="Screenshot from 2025-11-04 18-29-04" src="https://github.com/user-attachments/assets/ac775a01-dbe8-44d0-be2c-d33c5f5a90ee" /> #148 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 03:57:14 +01:00