[PR #1179] [MERGED] [gtk4] fix: correct action id message for workspace id change, fix failed firing with favorite workspaces #9635

New issue

Closed

opened 2026-05-23 03:57:08 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 03:57:08 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1179
Author: @tglman
Created: 9/28/2025
Status: ✅ Merged
Merged: 9/30/2025
Merged by: @JakeStanger

Base: refactor/gtk-4 ← Head: WIP_fix_favorite_workspaces

📝 Commits (1)

9f0cfc2 fix: correct action id message for workspace id change, fix failed firing with favorite workspaces

📊 Changes

1 file changed (+16 additions, -2 deletions)

View changed files

📝 src/modules/workspaces/button.rs (+16 -2)

📄 Description

Hi,

While testing I noticed issue with workspaces with niri, actually the issue is general with the workspace button, that can change id.

when workspace buttons change id that is not reflected in the event sent by the button, making the firing of the event not work correctly because of the wrong id.

This is evident when favorite workspaces are defined, favorite workspaces get defined with id -1, and when they get defined by the compositor and the id is changed that is not reflected in the firing of the events, making the workspace buttons of favorite workspaces not work.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1179 **Author:** [@tglman](https://github.com/tglman) **Created:** 9/28/2025 **Status:** ✅ Merged **Merged:** 9/30/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `refactor/gtk-4` ← **Head:** `WIP_fix_favorite_workspaces` --- ### 📝 Commits (1) - [`9f0cfc2`](https://github.com/JakeStanger/ironbar/commit/9f0cfc275207392d73837af58f5c082eab6218c0) fix: correct action id message for workspace id change, fix failed firing with favorite workspaces ### 📊 Changes **1 file changed** (+16 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/workspaces/button.rs` (+16 -2) </details> ### 📄 Description Hi, While testing I noticed issue with workspaces with niri, actually the issue is general with the workspace button, that can change id. when workspace buttons change id that is not reflected in the event sent by the button, making the firing of the event not work correctly because of the wrong id. This is evident when favorite workspaces are defined, favorite workspaces get defined with id -1, and when they get defined by the compositor and the id is changed that is not reflected in the firing of the events, making the workspace buttons of favorite workspaces not work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 03:57:08 +01:00