[PR #836] [MERGED] feat: keyboard layout module #9409

New issue

Closed

opened 2026-05-23 03:56:30 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 03:56:30 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/836
Author: @kuzy000
Created: 1/10/2025
Status: ✅ Merged
Merged: 2/3/2025
Merged by: @JakeStanger

Base: master ← Head: keyboard_layout

📝 Commits (3)

d2abc66 feat(keys): displaying and switching keyboard layout
746be82 docs(keys): keyboard layout docs
767011d refactor: rename keys module to keyboard

📊 Changes

15 files changed (+552 additions, -202 deletions)

View changed files

📝 Cargo.toml (+8 -7)
📝 docs/Compiling.md (+8 -4)
📝 docs/_Sidebar.md (+1 -1)
➕ docs/modules/Keyboard.md (+121 -0)
➖ docs/modules/Keys.md (+0 -102)
📝 nix/default.nix (+1 -1)
📝 src/clients/compositor/hyprland.rs (+119 -19)
📝 src/clients/compositor/mod.rs (+38 -3)
📝 src/clients/compositor/sway.rs (+89 -11)
📝 src/clients/mod.rs (+33 -3)
📝 src/config/mod.rs (+6 -6)
📝 src/image/gtk.rs (+2 -2)
📝 src/modules/keyboard.rs (+122 -37)
📝 src/modules/mod.rs (+2 -2)
📝 src/modules/workspaces/mod.rs (+2 -4)

📄 Description

Displays the current keyboard layout. Clicking switches to the next layout. Supports images. See docs/ for details.

Resolves https://github.com/JakeStanger/ironbar/issues/575.

Current concerns:

keyboard_layout is a clear name, but maybe it's too verbose?
Is it okay to add yet another channel in hyprland::Client?
Maybe I should rename layout_map to name_map to be consistent with workspaces module?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/836 **Author:** [@kuzy000](https://github.com/kuzy000) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 2/3/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `keyboard_layout` --- ### 📝 Commits (3) - [`d2abc66`](https://github.com/JakeStanger/ironbar/commit/d2abc6656fbaf357612453ce127478bcccc9195a) feat(keys): displaying and switching keyboard layout - [`746be82`](https://github.com/JakeStanger/ironbar/commit/746be82d90f75e7c9730ce48747648a94515581f) docs(keys): keyboard layout docs - [`767011d`](https://github.com/JakeStanger/ironbar/commit/767011d17b8dff646179e8986c14a808ed3a151d) refactor: rename `keys` module to `keyboard` ### 📊 Changes **15 files changed** (+552 additions, -202 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+8 -7) 📝 `docs/Compiling.md` (+8 -4) 📝 `docs/_Sidebar.md` (+1 -1) ➕ `docs/modules/Keyboard.md` (+121 -0) ➖ `docs/modules/Keys.md` (+0 -102) 📝 `nix/default.nix` (+1 -1) 📝 `src/clients/compositor/hyprland.rs` (+119 -19) 📝 `src/clients/compositor/mod.rs` (+38 -3) 📝 `src/clients/compositor/sway.rs` (+89 -11) 📝 `src/clients/mod.rs` (+33 -3) 📝 `src/config/mod.rs` (+6 -6) 📝 `src/image/gtk.rs` (+2 -2) 📝 `src/modules/keyboard.rs` (+122 -37) 📝 `src/modules/mod.rs` (+2 -2) 📝 `src/modules/workspaces/mod.rs` (+2 -4) </details> ### 📄 Description Displays the current keyboard layout. Clicking switches to the next layout. Supports images. See `docs/` for details. Resolves https://github.com/JakeStanger/ironbar/issues/575. Current concerns: 1. `keyboard_layout` is a clear name, but maybe it's too verbose? 2. Is it okay to add yet another channel in `hyprland::Client`? 3. Maybe I should rename `layout_map` to `name_map` to be consistent with workspaces module? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 03:56:30 +01:00