[PR #476] [MERGED] feat(launcher): item.name as fallback for app icon #9174

Closed
opened 2026-05-23 03:55:51 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/476
Author: @slowsage
Created: 2/26/2024
Status: Merged
Merged: 2/27/2024
Merged by: @JakeStanger

Base: masterHead: spotify-wayland-icon


📝 Commits (1)

  • f263849 fix(launcher): not resolving icon for some apps

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 src/modules/launcher/item.rs (+6 -2)

📄 Description

When using spotify in wayland with hyprland, the spotify icon is not pulled up correctly by the launcher module:
spotify --enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform=wayland
The class/app_id is "" while the name/title is "Spotify Premium". This uses item.name as a fallback which ensure spotify icon shows up correctly under wayland. Spotify under X11 does not have this problem.

Refs: #228, #146


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/476 **Author:** [@slowsage](https://github.com/slowsage) **Created:** 2/26/2024 **Status:** ✅ Merged **Merged:** 2/27/2024 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `spotify-wayland-icon` --- ### 📝 Commits (1) - [`f263849`](https://github.com/JakeStanger/ironbar/commit/f2638497fac4f0e350d069857e6e7437cb756669) fix(launcher): not resolving icon for some apps ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/launcher/item.rs` (+6 -2) </details> ### 📄 Description When using spotify in wayland with hyprland, the spotify icon is not pulled up correctly by the launcher module: `spotify --enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform=wayland` The class/app_id is "" while the name/title is "Spotify Premium". This uses item.name as a fallback which ensure spotify icon shows up correctly under wayland. Spotify under X11 does not have this problem. Refs: #228, #146 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-23 03:55:51 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#9174
No description provided.