mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 08:15:21 +01:00
[PR #476] [MERGED] feat(launcher): item.name as fallback for app icon #9174
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#9174
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/476
Author: @slowsage
Created: 2/26/2024
Status: ✅ Merged
Merged: 2/27/2024
Merged by: @JakeStanger
Base:
master← Head:spotify-wayland-icon📝 Commits (1)
f263849fix(launcher): not resolving icon for some apps📊 Changes
1 file changed (+6 additions, -2 deletions)
View changed files
📝
src/modules/launcher/item.rs(+6 -2)📄 Description
When using spotify in wayland with hyprland, the spotify icon is not pulled up correctly by the launcher module:
spotify --enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform=waylandThe class/app_id is "" while the name/title is "Spotify Premium". This uses item.name as a fallback which ensure spotify icon shows up correctly under wayland. Spotify under X11 does not have this problem.
Refs: #228, #146
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.