mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 11:15:20 +01:00
[PR #439] [MERGED] feat: enable use of markup in clock module formats #9153
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#9153
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/439
Author: @Dridus
Created: 2/7/2024
Status: ✅ Merged
Merged: 2/10/2024
Merged by: @JakeStanger
Base:
master← Head:rmm/clock-label-markup📝 Commits (1)
f4384b6feat: enable use of markup in clock module format and format_popup, and update documentation to reflect supporting Pango markup in both📊 Changes
2 files changed (+11 additions, -6 deletions)
View changed files
📝
docs/modules/Clock.md(+3 -3)📝
src/modules/clock.rs(+8 -3)📄 Description
hello! this PR makes a simple change to allow the use of pango markup in clock formats. the plain
labelmodule does this, so I figured it wouldn't be out of place.I read in the contributing guidance to open an issue or discussion as best practice, but since this is so small and I wanted it for myself I figured I'd just go straight to PR and I can close or revise it as you like.
thanks for writing ironbar!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.