[PR #371] [MERGED] refactor: begin restructuring core code to better encapsulate #9098

New issue

Closed

opened 2026-05-23 03:55:38 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 03:55:38 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/371
Author: @JakeStanger
Created: 12/8/2023
Status: ✅ Merged
Merged: 12/9/2023
Merged by: @JakeStanger

Base: master ← Head: refactor/encapsulate

📝 Commits (1)

b2fa19a refactor: begin restructuring core code to better encapsulate

📊 Changes

14 files changed (+493 additions, -418 deletions)

View changed files

📝 src/bar.rs (+222 -166)
📝 src/cli.rs (+0 -0)
📝 src/clients/system_tray.rs (+2 -3)
📝 src/clients/wayland/wlr_data_control/mod.rs (+2 -3)
📝 src/clients/wayland/wlr_foreign_toplevel/handle.rs (+2 -3)
📝 src/dynamic_value/dynamic_bool.rs (+3 -3)
📝 src/dynamic_value/dynamic_string.rs (+3 -3)
➖ src/global_state.rs (+0 -43)
📝 src/ipc/mod.rs (+1 -6)
📝 src/ipc/server.rs (+77 -63)
📝 src/ironvar.rs (+7 -11)
📝 src/main.rs (+162 -99)
📝 src/popup.rs (+12 -6)
➖ src/unique_id.rs (+0 -9)

📄 Description

This is a first pass towards trying to structure things a bit better, with data generally encapsulated under a single hierarchical tree, rather than lots of globals all over the place. Lots of work is still required.

The plan is that with this and some more work, #291 should become a lot easier to sort.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/371 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 12/8/2023 **Status:** ✅ Merged **Merged:** 12/9/2023 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `refactor/encapsulate` --- ### 📝 Commits (1) - [`b2fa19a`](https://github.com/JakeStanger/ironbar/commit/b2fa19ab6ce93e8865e9450ec58bf891e7380dd8) refactor: begin restructuring core code to better encapsulate ### 📊 Changes **14 files changed** (+493 additions, -418 deletions) <details> <summary>View changed files</summary> 📝 `src/bar.rs` (+222 -166) 📝 `src/cli.rs` (+0 -0) 📝 `src/clients/system_tray.rs` (+2 -3) 📝 `src/clients/wayland/wlr_data_control/mod.rs` (+2 -3) 📝 `src/clients/wayland/wlr_foreign_toplevel/handle.rs` (+2 -3) 📝 `src/dynamic_value/dynamic_bool.rs` (+3 -3) 📝 `src/dynamic_value/dynamic_string.rs` (+3 -3) ➖ `src/global_state.rs` (+0 -43) 📝 `src/ipc/mod.rs` (+1 -6) 📝 `src/ipc/server.rs` (+77 -63) 📝 `src/ironvar.rs` (+7 -11) 📝 `src/main.rs` (+162 -99) 📝 `src/popup.rs` (+12 -6) ➖ `src/unique_id.rs` (+0 -9) </details> ### 📄 Description This is a first pass towards trying to structure things a bit better, with data generally encapsulated under a single hierarchical tree, rather than lots of globals all over the place. Lots of work is still required. The plan is that with this and some more work, #291 should become a lot easier to sort. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 03:55:38 +01:00