[PR #140] [MERGED] [BREAKING] module-level `name` and `class` options #8939

New issue

Closed

opened 2026-05-23 03:55:11 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 03:55:11 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/140
Author: @JakeStanger
Created: 5/5/2023
Status: ✅ Merged
Merged: 5/6/2023
Merged by: @JakeStanger

Base: master ← Head: feat/better-styles

📝 Commits (1)

dea6641 feat: module-level name and class options

📊 Changes

30 files changed (+353 additions, -216 deletions)

View changed files

📝 docs/Configuration guide.md (+7 -4)
📝 docs/Styling guide.md (+29 -9)
📝 docs/modules/Clipboard.md (+10 -8)
📝 docs/modules/Clock.md (+6 -4)
📝 docs/modules/Custom.md (+8 -5)
📝 docs/modules/Focused.md (+7 -5)
📝 docs/modules/Label.md (+5 -3)
📝 docs/modules/Launcher.md (+9 -7)
📝 docs/modules/Music.md (+23 -21)
📝 docs/modules/Script.md (+5 -3)
📝 docs/modules/Sys-Info.md (+4 -2)
📝 docs/modules/Tray.md (+4 -2)
📝 docs/modules/Upower.md (+8 -6)
📝 docs/modules/Workspaces.md (+5 -3)
📝 examples/style.css (+32 -36)
➕ scripts/migrate-styles.sh (+72 -0)
📝 src/bar.rs (+7 -3)
📝 src/config/common.rs (+5 -2)
➕ src/gtk_helpers.rs (+8 -0)
📝 src/image/gtk.rs (+4 -3)

...and 10 more files

📄 Description

BREAKING CHANGE: To allow for the name property, any widgets that were previously targeted by name should be targeted by class instead. This affects all modules and all popups, as well as several widgets inside modules.

This will break a lot of rules in your stylesheet. To attempt to mitigate the damage, a migration script can be found here that should get you most of the way.

Resolves #75.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/140 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 5/5/2023 **Status:** ✅ Merged **Merged:** 5/6/2023 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `feat/better-styles` --- ### 📝 Commits (1) - [`dea6641`](https://github.com/JakeStanger/ironbar/commit/dea66415c2e11e34ba44d016aaa6cfb4ef7b9f9b) feat: module-level `name` and `class` options ### 📊 Changes **30 files changed** (+353 additions, -216 deletions) <details> <summary>View changed files</summary> 📝 `docs/Configuration guide.md` (+7 -4) 📝 `docs/Styling guide.md` (+29 -9) 📝 `docs/modules/Clipboard.md` (+10 -8) 📝 `docs/modules/Clock.md` (+6 -4) 📝 `docs/modules/Custom.md` (+8 -5) 📝 `docs/modules/Focused.md` (+7 -5) 📝 `docs/modules/Label.md` (+5 -3) 📝 `docs/modules/Launcher.md` (+9 -7) 📝 `docs/modules/Music.md` (+23 -21) 📝 `docs/modules/Script.md` (+5 -3) 📝 `docs/modules/Sys-Info.md` (+4 -2) 📝 `docs/modules/Tray.md` (+4 -2) 📝 `docs/modules/Upower.md` (+8 -6) 📝 `docs/modules/Workspaces.md` (+5 -3) 📝 `examples/style.css` (+32 -36) ➕ `scripts/migrate-styles.sh` (+72 -0) 📝 `src/bar.rs` (+7 -3) 📝 `src/config/common.rs` (+5 -2) ➕ `src/gtk_helpers.rs` (+8 -0) 📝 `src/image/gtk.rs` (+4 -3) _...and 10 more files_ </details> ### 📄 Description BREAKING CHANGE: To allow for the `name` property, any widgets that were previously targeted by name should be targeted by class instead. This affects **all modules and all popups**, as well as several widgets inside modules. **This will break a lot of rules in your stylesheet**. To attempt to mitigate the damage, a migration script can be found [here](https://raw.githubusercontent.com/JakeStanger/ironbar/master/scripts/migrate-styles.sh) that should get you most of the way. Resolves #75. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 03:55:11 +01:00