[PR #111] [MERGED] fix(script): parser incorrectly handling colons #8921

Closed
opened 2026-05-23 03:55:08 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/111
Author: @JakeStanger
Created: 4/20/2023
Status: Merged
Merged: 4/21/2023
Merged by: @JakeStanger

Base: masterHead: fix/script-parsing


📝 Commits (1)

  • 15a9d8d fix(script): parser incorrectly handling colons

📊 Changes

1 file changed (+64 additions, -30 deletions)

View changed files

📝 src/script.rs (+64 -30)

📄 Description

The short input parser was previously splitting colons, and incorrectly handling situations where the cmd section contained colons. The parser now properly checks input in the mode:interval:cmd format, moving onto the next section regardless of whether the previous was found.

This means unless your script literally starts with poll: or 5000: you won't hit this issue anymore.

Hopefully resolves #94.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/111 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 4/20/2023 **Status:** ✅ Merged **Merged:** 4/21/2023 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/script-parsing` --- ### 📝 Commits (1) - [`15a9d8d`](https://github.com/JakeStanger/ironbar/commit/15a9d8d42c9319a7062e6a90086e0c1c3323f5d8) fix(script): parser incorrectly handling colons ### 📊 Changes **1 file changed** (+64 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/script.rs` (+64 -30) </details> ### 📄 Description The short input parser was previously splitting colons, and incorrectly handling situations where the `cmd` section contained colons. The parser now properly checks input in the `mode:interval:cmd` format, moving onto the next section regardless of whether the previous was found. This means unless your script literally starts with `poll:` or `5000:` you won't hit this issue anymore. Hopefully resolves #94. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-23 03:55:08 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#8921
No description provided.