mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 07:15:19 +01:00
[GH-ISSUE #809] vlc tray icon not respecting icon_size #8681
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#8681
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @salahoued on GitHub (Dec 9, 2024).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/809
Describe the bug
I'm not sure if this is an
ironbarissue or a vlc one, but when vlc (flatpak) is launched, its tray icon is shown inironbartoo big which causes the bar height to grow bigTo Reproduce
Steps to reproduce the behavior:
Expected behavior
tray icons should respect the
icon_sizeoption in the config, or if not declared should respect the barheightSystem information:
Configuration
Config
Styles
Additional context
Screenshots
@ToxicMushroom commented on GitHub (Dec 11, 2024):
I noticed the same with fcitx5
@JakeStanger commented on GitHub (Dec 11, 2024):
@ToxicMushroom what package manager did you use to install it? I was suspicious of Flatpak but that might blow that out the window
@ToxicMushroom commented on GitHub (Dec 11, 2024):
Pacman
1 extra/fcitx5 5.1.11-1 [0 B 17.25 MiB] [Installed] (fcitx5-im)@JakeStanger commented on GitHub (Dec 11, 2024):
Right, well it's not Flatpak then. New theory is that when the tray provides its on pixmap that's not being scaled down (properly).
@salahoued commented on GitHub (Dec 11, 2024):
@JakeStanger , It may have something to do with the
icon_themeused.when using

breezeorbreeze-darkwhen using

Breeze-Darkwith capital letters it falls back to the default one and it works fine the icon (vlc's) shows correctlythe same for

Papirus-Darkit worked fine too@ogios commented on GitHub (Dec 12, 2024):
we can force scale it ourself.
scale = icon_size / actual_height, and use image surface to redraw it or some other way.
use height/width for horizontal/vetical bar.
this is an example
@JakeStanger commented on GitHub (Dec 15, 2024):
Hm yeah, buggy icon themes could be a problem. It may be possible to perform a check on the size of the loaded image and scale that, as I don't think the above PR will account for icons from the theme.
@ogios commented on GitHub (Dec 16, 2024):
some theme don't have the size we wanted, and the difference can be big