mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 10:15:20 +01:00
[GH-ISSUE #650] Support Niri out of the box #8649
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#8649
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @VarLad on GitHub (Jun 28, 2024).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/650
Is your feature request related to a problem? Please describe.
Describe the solution you'd like
Support Niri workspaces out of the box. What would be required to do this?
@JakeStanger commented on GitHub (Jun 28, 2024):
Yes, happy for this to be added.
I've had a brief look at Niri's IPC and it looks like it's missing events, which would make this tricky. Without those, Ironbar would have to constantly poll Niri to find the focused workspace, as it won't be notified of changes. I might be missing something though.
Assuming that can be resolved, the rest shouldn't be too hard, especially since Niri provides rust types for its IPC. Effectively entries would need to be added to the compositor client code to spawn a Niri client here and a new client would need to be written which implements the WorkspaceClient trait
github.com/JakeStanger/ironbar@6a06fa534a/src/clients/compositor/mod.rs (L142-L148)@VarLad commented on GitHub (Jun 29, 2024):
@JakeStanger Does it make sense to wait for https://github.com/YaLTeR/niri/pull/453 then?
@JakeStanger commented on GitHub (Jun 29, 2024):
Aha. Yeah definitely so, I'll mark this as blocked for now.
@Brisingr05 commented on GitHub (Aug 30, 2024):
@JakeStanger
Work on the event stream IPC has progressed and the niri dev is wondering if there are any design flaws that need to be worked on. There are some details in the PR linked above. I'm not a programmer but I'm willing to helping in testing.The PR has been merged.