mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 09:15:22 +01:00
[GH-ISSUE #84] Tray issues #8480
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#8480
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dchinmay2 on GitHub (Mar 19, 2023).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/84
Describe the bug
When I use the tray icon from
nm-applet,The icons don't get updated (for example the icon should become a lock when a VPN is enabled but this doesn't happen until I restart the bar)
There are no checkboxes (each of the three vpn connections is supposed to have a checkbox to its left)

The bar crashes after some time of interacting with tray items:
https://paste.sr.ht/~p00f/6c6afbfd14a1aacaee2ba6d49cb9e582323eded4
Clicking buttons doesn't work in the main dropdown
To Reproduce
Steps to reproduce the behavior:
nm-applet --indicatorSystem information:
Configuration
Config
Styles
@JakeStanger commented on GitHub (Mar 19, 2023):
Thanks for the detailed report.
Paging @oknozor. This looks like the error is coming from
stray. I am not sure if the other problems are ones you're aware of / looking at in #65?@oknozor commented on GitHub (Mar 20, 2023):
I am pretty sure this is related to the gtk view implementation, I had a similar issues trying to implement system tray for eww (see: https://github.com/elkowar/eww/pull/448). Unfortunately I short on time these days and lack the gtk-rs knowledge to fix this.
If I recall correctly this require a custom implementation of
MenuModel. Maybe a a seasoned gtk developer could help here ?@JakeStanger commented on GitHub (Feb 1, 2024):
Apologies it took me so long to get round to this one, but I've finally had the time/patience to dive into this and give it the attention it deserves.
I've almost entirely rewritten the module, which fixes all of the above issues. I've also made some changes to the underlying library to fix a few issues, and the module should be much more robust now. It still isn't perfect, but it's a lot better than it was.
The rewrite should also come with some serious performance gains for the module. Previously the entire menu UI was recreated for every update (every image change is an update, which for
nm-appletmeant every animation of connecting/disconnecting), whereas now it will do a diff and efficiently update only what needs changing. It's ended up working in much the same way React does, which is kinda cool I guess.