[PR #1439] [MERGED] fix: issue with favorite workspace buttons not working for inactive/empty workspaces #964 #8393

New issue

Closed

opened 2026-05-23 02:57:27 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 02:57:27 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1439
Author: @CameronBarnes
Created: 4/2/2026
Status: ✅ Merged
Merged: 4/13/2026
Merged by: @JakeStanger

Base: master ← Head: master

📝 Commits (1)

f42c41f fix: issue with favorite workspace buttons not working for inactive/empty workspaces #964

📊 Changes

1 file changed (+22 additions, -5 deletions)

View changed files

📝 src/modules/workspaces/mod.rs (+22 -5)

📄 Description

Favorite workspace buttons use a default workspace id value of -1 which is not generally an active or valid workspace and does not usually align with numbered favorite workspaces.
Parse the name into a number where possible to resolve that issue, and adjust how removing workspace buttons occurrs to prevent this from being undone.
A separate fix is likely required to address issues with favorite workspaces with non-numerical names.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1439 **Author:** [@CameronBarnes](https://github.com/CameronBarnes) **Created:** 4/2/2026 **Status:** ✅ Merged **Merged:** 4/13/2026 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`f42c41f`](https://github.com/JakeStanger/ironbar/commit/f42c41f67b030336c1493ec49ef9c084c4c1a7db) fix: issue with favorite workspace buttons not working for inactive/empty workspaces #964 ### 📊 Changes **1 file changed** (+22 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/workspaces/mod.rs` (+22 -5) </details> ### 📄 Description Favorite workspace buttons use a default workspace id value of -1 which is not generally an active or valid workspace and does not usually align with numbered favorite workspaces. Parse the name into a number where possible to resolve that issue, and adjust how removing workspace buttons occurrs to prevent this from being undone. A separate fix is likely required to address issues with favorite workspaces with non-numerical names. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 02:57:27 +01:00