[PR #621] [MERGED] Fix Pango markup not escaped #833

New issue

Closed

opened 2026-05-22 21:54:45 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 21:54:45 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/621
Author: @JakeStanger
Created: 6/2/2024
Status: ✅ Merged
Merged: 6/2/2024
Merged by: @JakeStanger

Base: master ← Head: fix/markup-escape

📝 Commits (2)

9d8a3eb fix: correctly escape pango markup
b8fdd85 refactor: explicitly use set_text on non-pango labels

📊 Changes

14 files changed (+40 additions, -23 deletions)

View changed files

📝 src/dynamic_value/dynamic_string.rs (+1 -1)
📝 src/gtk_helpers.rs (+15 -2)
📝 src/modules/clock.rs (+2 -2)
📝 src/modules/custom/button.rs (+2 -1)
📝 src/modules/custom/label.rs (+2 -1)
📝 src/modules/focused.rs (+1 -1)
📝 src/modules/label.rs (+2 -1)
📝 src/modules/music/mod.rs (+5 -5)
📝 src/modules/notifications.rs (+1 -1)
📝 src/modules/script.rs (+2 -1)
📝 src/modules/sysinfo.rs (+2 -2)
📝 src/modules/tray/interface.rs (+1 -1)
📝 src/modules/upower.rs (+3 -3)
📝 src/modules/volume.rs (+1 -1)

📄 Description

Fixes issues where eg song title could contain an &, which would not display and log a GTK warning.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/621 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 6/2/2024 **Status:** ✅ Merged **Merged:** 6/2/2024 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/markup-escape` --- ### 📝 Commits (2) - [`9d8a3eb`](https://github.com/JakeStanger/ironbar/commit/9d8a3eb370195321d224c0a51a6752c62404ac1b) fix: correctly escape pango markup - [`b8fdd85`](https://github.com/JakeStanger/ironbar/commit/b8fdd8531e5516598f81e869b9284b8888f1d06b) refactor: explicitly use `set_text` on non-pango labels ### 📊 Changes **14 files changed** (+40 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/dynamic_value/dynamic_string.rs` (+1 -1) 📝 `src/gtk_helpers.rs` (+15 -2) 📝 `src/modules/clock.rs` (+2 -2) 📝 `src/modules/custom/button.rs` (+2 -1) 📝 `src/modules/custom/label.rs` (+2 -1) 📝 `src/modules/focused.rs` (+1 -1) 📝 `src/modules/label.rs` (+2 -1) 📝 `src/modules/music/mod.rs` (+5 -5) 📝 `src/modules/notifications.rs` (+1 -1) 📝 `src/modules/script.rs` (+2 -1) 📝 `src/modules/sysinfo.rs` (+2 -2) 📝 `src/modules/tray/interface.rs` (+1 -1) 📝 `src/modules/upower.rs` (+3 -3) 📝 `src/modules/volume.rs` (+1 -1) </details> ### 📄 Description Fixes issues where eg song title could contain an `&`, which would not display and log a GTK warning. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 21:54:45 +01:00