[PR #1201] [MERGED] refactor: generate completions using cli instead of build #8247

New issue

Closed

opened 2026-05-23 02:57:03 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 02:57:03 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1201
Author: @JakeStanger
Created: 10/19/2025
Status: ✅ Merged
Merged: 10/19/2025
Merged by: @JakeStanger

Base: master ← Head: refactor/completions

📝 Commits (1)

557b9b8 refactor: generate completions using cli instead of build

📊 Changes

41 files changed (+175 additions, -182 deletions)

View changed files

📝 .github/workflows/build.yml (+1 -1)
📝 Cargo.lock (+2 -2)
📝 Cargo.toml (+4 -8)
➖ build.rs (+0 -53)
📝 docs/Compiling.md (+44 -43)
📝 nix/package.nix (+5 -0)
📝 src/cli.rs (+34 -6)
📝 src/config/common.rs (+4 -4)
📝 src/config/impl.rs (+1 -1)
📝 src/config/layout.rs (+1 -1)
📝 src/config/mod.rs (+8 -8)
📝 src/config/truncate.rs (+2 -2)
📝 src/dynamic_value/dynamic_bool.rs (+1 -1)
📝 src/main.rs (+16 -1)
📝 src/modules/battery.rs (+1 -1)
📝 src/modules/bindmode.rs (+1 -1)
📝 src/modules/bluetooth/config.rs (+6 -6)
📝 src/modules/cairo.rs (+1 -1)
📝 src/modules/clipboard.rs (+1 -1)
📝 src/modules/clock.rs (+1 -1)

...and 21 more files

📄 Description

This should have a slight incremental compliation speed boost.

BREAKING CHANGE: The schema feature flag is now called extras.

BREAKING CHANGE: Shell completions are no longer generated at build time, and must be generated using ironbar --print-completions <shell>

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1201 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 10/19/2025 **Status:** ✅ Merged **Merged:** 10/19/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `refactor/completions` --- ### 📝 Commits (1) - [`557b9b8`](https://github.com/JakeStanger/ironbar/commit/557b9b870c0ebc2e01c070edd70d565d42b969a6) refactor: generate completions using cli instead of build ### 📊 Changes **41 files changed** (+175 additions, -182 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+1 -1) 📝 `Cargo.lock` (+2 -2) 📝 `Cargo.toml` (+4 -8) ➖ `build.rs` (+0 -53) 📝 `docs/Compiling.md` (+44 -43) 📝 `nix/package.nix` (+5 -0) 📝 `src/cli.rs` (+34 -6) 📝 `src/config/common.rs` (+4 -4) 📝 `src/config/impl.rs` (+1 -1) 📝 `src/config/layout.rs` (+1 -1) 📝 `src/config/mod.rs` (+8 -8) 📝 `src/config/truncate.rs` (+2 -2) 📝 `src/dynamic_value/dynamic_bool.rs` (+1 -1) 📝 `src/main.rs` (+16 -1) 📝 `src/modules/battery.rs` (+1 -1) 📝 `src/modules/bindmode.rs` (+1 -1) 📝 `src/modules/bluetooth/config.rs` (+6 -6) 📝 `src/modules/cairo.rs` (+1 -1) 📝 `src/modules/clipboard.rs` (+1 -1) 📝 `src/modules/clock.rs` (+1 -1) _...and 21 more files_ </details> ### 📄 Description This should have a slight incremental compliation speed boost. BREAKING CHANGE: The `schema` feature flag is now called `extras`. BREAKING CHANGE: Shell completions are no longer generated at build time, and must be generated using `ironbar --print-completions <shell>` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 02:57:03 +01:00