[PR #1046] [MERGED] fix(nix): default HM module `config` option to `null` #8134

New issue

Closed

opened 2026-05-23 02:56:44 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 02:56:44 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1046
Author: @postsolar
Created: 6/14/2025
Status: ✅ Merged
Merged: 6/16/2025
Merged by: @JakeStanger

Base: master ← Head: fix/hm-settings

📝 Commits (1)

9b0c0dd fix: default HM module config option to null

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 nix/module.nix (+2 -2)

📄 Description

This makes it more semantically approachable IMO.

I would expect this behavior:

Default value is null
Config is created if the value is not null
Option unset (i.e. the default) => no config created
This matches a lot of other HM modules

Currently it's this behavior (makes little sense to me):

Default value is {}
Config is created if the values is not ""
Need to explicitly set the option to "" in order to not create a config

This would be a breaking change for:

People who were setting the option to "" to achieve not creating a config
(Contrived) People who needed some sort of a nonsense config like {}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1046 **Author:** [@postsolar](https://github.com/postsolar) **Created:** 6/14/2025 **Status:** ✅ Merged **Merged:** 6/16/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/hm-settings` --- ### 📝 Commits (1) - [`9b0c0dd`](https://github.com/JakeStanger/ironbar/commit/9b0c0dd0fe557ad47bfe7fad9c82d4a607ce4963) fix: default HM module `config` option to `null` ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `nix/module.nix` (+2 -2) </details> ### 📄 Description This makes it more semantically approachable IMO. I would expect this behavior: - Default value is `null` - Config is created if the value is not `null` - Option unset (i.e. the default) => no config created - This matches a lot of other HM modules Currently it's this behavior (makes little sense to me): - Default value is `{}` - Config is created if the values is not `""` - Need to explicitly set the option to `""` in order to not create a config This would be a breaking change for: - People who were setting the option to `""` to achieve not creating a config - (Contrived) People who needed some sort of a nonsense config like `{}` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 02:56:44 +01:00