[PR #968] [MERGED] fix(music): Fix hours not being displayed in track duration #8091

Closed
opened 2026-05-23 02:56:37 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/968
Author: @postsolar
Created: 5/12/2025
Status: Merged
Merged: 5/12/2025
Merged by: @JakeStanger

Base: masterHead: music-duration-hours


📝 Commits (1)

  • a56a341 fix hours not being displayed in track duration

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 src/modules/music/mod.rs (+7 -2)

📄 Description

Closes #967

20250512_10h48m20s_grim

As for the UI I think the convention is to:

  • Not pad it with zeros
  • Only display hours if track duration is longer than 60 minutes

For instance, that's how SoundCloud displays duration.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/968 **Author:** [@postsolar](https://github.com/postsolar) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/12/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `music-duration-hours` --- ### 📝 Commits (1) - [`a56a341`](https://github.com/JakeStanger/ironbar/commit/a56a341f16d9458d55b69d130cf42e1d18c53778) fix hours not being displayed in track duration ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/music/mod.rs` (+7 -2) </details> ### 📄 Description Closes #967 ![20250512_10h48m20s_grim](https://github.com/user-attachments/assets/0a1df0c7-529f-431f-8e46-f4955b7a06a2) As for the UI I think the convention is to: - Not pad it with zeros - Only display hours if track duration is longer than 60 minutes For instance, that's how SoundCloud displays duration. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-23 02:56:37 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#8091
No description provided.