[PR #766] [MERGED] A whole load of tray fixes 🎉 #7957

New issue

Closed

opened 2026-05-23 02:56:15 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 02:56:15 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/766
Author: @JakeStanger
Created: 11/8/2024
Status: ✅ Merged
Merged: 11/9/2024
Merged by: @JakeStanger

Base: master ← Head: fix/tray-fixes

📝 Commits (6)

55c0940 fix(tray): update system-tray dep to bring in a whole load of fixes
fb17995 fix(tray): image updates lag 1 behind
662ddb6 feat(tray): image support in menu items
486beff refactor: put in basic placeholders for menu icon diffs
cf38c37 refactor(tray): move some debug logging to trace logging
f1e8783 chore: tidy main

📊 Changes

8 files changed (+224 additions, -67 deletions)

View changed files

📝 Cargo.lock (+125 -41)
📝 Cargo.toml (+3 -2)
📝 src/clients/mod.rs (+2 -4)
📝 src/main.rs (+1 -1)
📝 src/modules/tray/diff.rs (+5 -2)
📝 src/modules/tray/icon.rs (+34 -0)
📝 src/modules/tray/interface.rs (+50 -13)
📝 src/modules/tray/mod.rs (+4 -4)

📄 Description

This PR, accompanied by https://github.com/JakeStanger/system-tray/pull/2 includes a very long-overdue set of fixes for the tray module.

Effectively:

A proper (mostly, I think) spec-compliant host has been ported from eww by @ToxicMushroom which means Ironbar plays a lot nicer with other trays now.
The eww code and some additional fixes mean that Ironbar is more tolerant to the many non-spec complaint programs out there. Although it's not perfect, this means:
- Icons should be a lot less likely to not show.
- Icons should be a lot less likely to duplicate.
Tray icons now correctly receive updates, which means you'll see for example nm-applet animate when connecting.
Menu separators now show.
Menu items will now show their icons (check out VLC!).
Any funny situations should be less likely to cause the whole thing to crash.

To the best of my knowledge, from my own testing I believe that means the below can be closed. Any issues let me know & we can re-open.

Fixes #632
Fixes #640
Fixes #645
Fixes #647
Fixes #672
Fixes #714
Fixes #751

Phew.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/766 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 11/8/2024 **Status:** ✅ Merged **Merged:** 11/9/2024 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/tray-fixes` --- ### 📝 Commits (6) - [`55c0940`](https://github.com/JakeStanger/ironbar/commit/55c0940e1dc90069018e40254a2b079b31bc2da2) fix(tray): update `system-tray` dep to bring in a whole load of fixes - [`fb17995`](https://github.com/JakeStanger/ironbar/commit/fb1799531b4638f8cd3a36ccb94425643aaa6082) fix(tray): image updates lag 1 behind - [`662ddb6`](https://github.com/JakeStanger/ironbar/commit/662ddb69464ab45546231d337f7f4f3e5efcdc98) feat(tray): image support in menu items - [`486beff`](https://github.com/JakeStanger/ironbar/commit/486beff8a550e0bc757e79ea37c450cab3a810eb) refactor: put in basic placeholders for menu icon diffs - [`cf38c37`](https://github.com/JakeStanger/ironbar/commit/cf38c37fe3223280bf89e50b6869e1912a8ed8bf) refactor(tray): move some debug logging to trace logging - [`f1e8783`](https://github.com/JakeStanger/ironbar/commit/f1e87830ed6c8383ff67a1f2774a50cb575210c3) chore: tidy main ### 📊 Changes **8 files changed** (+224 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+125 -41) 📝 `Cargo.toml` (+3 -2) 📝 `src/clients/mod.rs` (+2 -4) 📝 `src/main.rs` (+1 -1) 📝 `src/modules/tray/diff.rs` (+5 -2) 📝 `src/modules/tray/icon.rs` (+34 -0) 📝 `src/modules/tray/interface.rs` (+50 -13) 📝 `src/modules/tray/mod.rs` (+4 -4) </details> ### 📄 Description This PR, accompanied by https://github.com/JakeStanger/system-tray/pull/2 includes a *very* long-overdue set of fixes for the tray module. Effectively: - A proper (mostly, I think) spec-compliant host has been ported from eww by @ToxicMushroom which means Ironbar plays a lot nicer with other trays now. - The eww code and some additional fixes mean that Ironbar is more tolerant to the ***many*** non-spec complaint programs out there. Although it's not perfect, this means: - Icons should be a lot less likely to not show. - Icons should be a lot less likely to duplicate. - Tray icons now correctly receive updates, which means you'll see for example `nm-applet` animate when connecting. - Menu separators now show. - Menu items will now show their icons (check out VLC!). - Any funny situations should be less likely to cause the whole thing to crash. To the best of my knowledge, from my own testing I believe that means the below can be closed. Any issues let me know & we can re-open. Fixes #632 Fixes #640 Fixes #645 Fixes #647 Fixes #672 Fixes #714 Fixes #751 Phew. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 02:56:15 +01:00