mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 07:15:19 +01:00
[PR #690] One icon per connection type in NetworkManager module #7900
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#7900
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/690
Author: @Zedfrigg
Created: 8/4/2024
Status: 🔄 Open
Base:
master← Head:feat/networkmanager-multi-icon📝 Commits (10+)
05e0083feat: add networkmanager module3e9cf85Merge branch 'JakeStanger:master' into feat/networkmanager33d367cfeat: networkmanager module is now an optional Cargo featureb92c8d6feat: add icon size config and cellular support to networkmanager moduleb96d696docs: add networkmanager module documentation4b40455Merge branch 'JakeStanger:master' into feat/networkmanager4df4805docs: remove todo for icon size configcdc196dfix: missing cfg attribute for networkmanager module in bar loading85db13dfix: yet another missing cfg attribute for networkmanager module9031438Merge branch 'master' into feat/networkmanager📊 Changes
8 files changed (+498 additions, -297 deletions)
View changed files
📝
Cargo.lock(+12 -64)📝
Cargo.toml(+2 -2)📝
src/clients/mod.rs(+1 -1)➖
src/clients/networkmanager.rs(+0 -171)➕
src/clients/networkmanager/dbus.rs(+84 -0)➕
src/clients/networkmanager/event.rs(+18 -0)➕
src/clients/networkmanager/mod.rs(+239 -0)📝
src/modules/networkmanager.rs(+142 -59)📄 Description
Draft PR to track the status of the implementation. Will watch all NM connections and figure out if they should be categorised as ethernet, wifi, cellular, VPN or other. If there is at least one connection in a category, an icon will be shown for it indicating its status in more detail.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.