[PR #547] [MERGED] Fix #546: Convert from ARGB32 to RGBA32 formats for Pixmaps #790

Closed
opened 2026-05-22 21:54:37 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/547
Author: @rdnelson
Created: 4/21/2024
Status: Merged
Merged: 4/24/2024
Merged by: @JakeStanger

Base: masterHead: trayRgbaFix


📝 Commits (2)

  • 6651fa2 Fix #546: Convert from ARGB32 to RGBA32 formats when rendering tray Pixmaps
  • c291512 Fix cargo formatting errors.

📊 Changes

1 file changed (+13 additions, -1 deletions)

View changed files

📝 src/modules/tray/icon.rs (+13 -1)

📄 Description

Simple change to swap the channel order of the incoming pixmap data from ARGB to RGBA before creating the pixbuf.

Using the same icon as the one I added in the issue, it now renders like this, which is much more accurate to the original.

2024-04-21T19:12:29,362148653-04:00

Also I'm still very new to rust, so if there's a cleaner way to do this please let me know.

Fixes #546


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/547 **Author:** [@rdnelson](https://github.com/rdnelson) **Created:** 4/21/2024 **Status:** ✅ Merged **Merged:** 4/24/2024 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `trayRgbaFix` --- ### 📝 Commits (2) - [`6651fa2`](https://github.com/JakeStanger/ironbar/commit/6651fa23409417e7dac5c31460357aeb307b53cf) Fix #546: Convert from ARGB32 to RGBA32 formats when rendering tray Pixmaps - [`c291512`](https://github.com/JakeStanger/ironbar/commit/c29151248a4f7b1450e781d9d5038567ae3579e2) Fix cargo formatting errors. ### 📊 Changes **1 file changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/tray/icon.rs` (+13 -1) </details> ### 📄 Description Simple change to swap the channel order of the incoming pixmap data from ARGB to RGBA before creating the pixbuf. Using the same icon as the one I added in the issue, it now renders like this, which is much more accurate to the original. ![2024-04-21T19:12:29,362148653-04:00](https://github.com/JakeStanger/ironbar/assets/1231364/cdd9500a-e4c2-45a2-acc9-6ae35104da0e) Also I'm still very new to rust, so if there's a cleaner way to do this please let me know. Fixes #546 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-22 21:54:37 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#790
No description provided.