[PR #599] [MERGED] Fix reload bug #7848

New issue

Closed

opened 2026-05-23 02:55:57 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 02:55:57 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/599
Author: @SerraPi
Created: 5/19/2024
Status: ✅ Merged
Merged: 5/19/2024
Merged by: @JakeStanger

Base: master ← Head: patch-1

📝 Commits (1)

bb04026 Fix main.rs

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/main.rs (+1 -1)

📄 Description

let index = match index {
    Some(index) => index - 1,
    None => {
        lock!(map).push(monitor_name.clone());
        lock!(map).len() - 1
    }
};

//This causes index to underflow
//Expected Output is something like 0, 1, etc
//But sometimes we go back around to 18446744073709551615

//Removing the index -1 here seems to work ok with multi monitor, and reload is not broken anymore

Fixes #598

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/599 **Author:** [@SerraPi](https://github.com/SerraPi) **Created:** 5/19/2024 **Status:** ✅ Merged **Merged:** 5/19/2024 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`bb04026`](https://github.com/JakeStanger/ironbar/commit/bb040266baaeeac85f7d8a5d89de64b9c2673ab7) Fix main.rs ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/main.rs` (+1 -1) </details> ### 📄 Description let index = match index { Some(index) => index - 1, None => { lock!(map).push(monitor_name.clone()); lock!(map).len() - 1 } }; //This causes index to underflow //Expected Output is something like 0, 1, etc //But sometimes we go back around to 18446744073709551615 //Removing the index -1 here seems to work ok with multi monitor, and reload is not broken anymore Fixes #598 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 02:55:57 +01:00