[PR #459] [MERGED] fix(popup): re-position on resize due to content change #732

New issue

Closed

opened 2026-05-22 21:54:26 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 21:54:26 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/459
Author: @JakeStanger
Created: 2/18/2024
Status: ✅ Merged
Merged: 2/18/2024
Merged by: @JakeStanger

Base: master ← Head: fix/popup-resize

📝 Commits (2)

a55ba8c refactor: rename get_orientation method to orientation
a10466e fix(popup): re-position on resize due to content change

📊 Changes

12 files changed (+114 additions, -81 deletions)

View changed files

📝 src/bar.rs (+8 -9)
📝 src/config/impl.rs (+1 -1)
📝 src/ipc/server.rs (+7 -8)
📝 src/modules/custom/mod.rs (+2 -2)
📝 src/modules/focused.rs (+1 -1)
📝 src/modules/launcher/item.rs (+1 -3)
📝 src/modules/launcher/mod.rs (+1 -1)
📝 src/modules/mod.rs (+3 -20)
📝 src/modules/sysinfo.rs (+1 -1)
📝 src/modules/tray/mod.rs (+1 -1)
📝 src/modules/workspaces.rs (+1 -1)
📝 src/popup.rs (+87 -33)

📄 Description

Popups will now correctly re-anchor themselves to the button that opened them if the content resizes.

This should also fix some long-standing issues where popups are occasionally opened in the wrong place first time they are opened.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/459 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 2/18/2024 **Status:** ✅ Merged **Merged:** 2/18/2024 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/popup-resize` --- ### 📝 Commits (2) - [`a55ba8c`](https://github.com/JakeStanger/ironbar/commit/a55ba8c523ff19fa607a31bac589a55b48db39ad) refactor: rename `get_orientation` method to `orientation` - [`a10466e`](https://github.com/JakeStanger/ironbar/commit/a10466e7e9dafd29e80994eccccdd398e9434b95) fix(popup): re-position on resize due to content change ### 📊 Changes **12 files changed** (+114 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `src/bar.rs` (+8 -9) 📝 `src/config/impl.rs` (+1 -1) 📝 `src/ipc/server.rs` (+7 -8) 📝 `src/modules/custom/mod.rs` (+2 -2) 📝 `src/modules/focused.rs` (+1 -1) 📝 `src/modules/launcher/item.rs` (+1 -3) 📝 `src/modules/launcher/mod.rs` (+1 -1) 📝 `src/modules/mod.rs` (+3 -20) 📝 `src/modules/sysinfo.rs` (+1 -1) 📝 `src/modules/tray/mod.rs` (+1 -1) 📝 `src/modules/workspaces.rs` (+1 -1) 📝 `src/popup.rs` (+87 -33) </details> ### 📄 Description Popups will now correctly re-anchor themselves to the button that opened them if the content resizes. This should also fix some long-standing issues where popups are occasionally opened in the wrong place first time they are opened. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 21:54:26 +01:00