mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 09:15:22 +01:00
[GH-ISSUE #606] Dialog Menus show up in launcher #7224
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#7224
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ClaireNeveu on GitHub (May 22, 2024).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/606
Describe the bug
Sub-windows in an application (like dialog menus) appear in the launcher when open.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The launcher should not display a new item.
System information:
Configuration
Config
Styles
Additional context
This might be related to Krita getting stuck in the launcher since it opens a lot of subwindows.
Screenshots
@ClaireNeveu commented on GitHub (May 22, 2024):
Still working on getting a minimum repro on the Krita issue, it doesn't happen if you close Krita right away but consistently after I've been drawing for an hour or two and close it, ironbar thinks it's still running until I restart ironbar.
@JakeStanger commented on GitHub (May 22, 2024):
I've got a feeling this is going to be an easy fix, or nigh impossible. Out of interest, do you know whether krita is native or xwayland?
@ClaireNeveu commented on GitHub (May 22, 2024):
Krita is an xwayland app.
@JakeStanger commented on GitHub (May 22, 2024):
In theory, I think it should be possible to detect if a window has a parent window using
wlr_foreign_toplevel_management, which is already hooked up. This means it should be easy.As far as I can see though, Hyprland never sends that info, so I need to dig a bit deeper and see if another compositor does and if it'll help.
As an aside, I had krita open to test and hit the same bug where it doesn't close properly. I did open a single dialog. It seems strange I've never seen this occur with anything else. My Jetbrains IDEs are all xwayland and spam child windows like nothing else so I don't think that's the culprit.
@ClaireNeveu commented on GitHub (May 22, 2024):
Hmm, this might be a bug in Hyprland, they just did a big rewrite with 0.40.0.
@JakeStanger commented on GitHub (Jun 13, 2024):
...and an even bigger one with 0.41.0. Hyprland isn't particularly stable right now as a result, but I'd be interested to know if you still have the issue after updating.
@ClaireNeveu commented on GitHub (Jun 17, 2024):
This does still happen on 0.41.x
@ClaireNeveu commented on GitHub (Jun 18, 2024):
0.41.x is even more broken than 0.40.x it seems so take that for what it is.
@donovanglover commented on GitHub (Jul 15, 2024):
Also occurs with 0.41.2 and hovering over links that have titles in xwayland chromium
@JakeStanger commented on GitHub (Aug 14, 2024):
Still occurs in v0.42.0
I've seen this quite a few times with different apps myself and every time it seems to be xwayland. A little bit of digging seems to show that these are created as xwayland windows with no title/class.
I'm going to try filtering those out and we'll see if that sorts it. At the very least, it should help mitigate it.
@JakeStanger commented on GitHub (Aug 14, 2024):
This seems to have caught all the examples I know of, at least. Any further issues let me know and I'll re-open.