mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 08:15:21 +01:00
[GH-ISSUE #469] Hyprland renamed workspaces not displaying correctly #7183
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#7183
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @m-bartlett on GitHub (Feb 24, 2024).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/469
Describe the bug
When using the
renameworkspacedispatcher in Hyprland to rename a workspace, the workspace module keeps a ghost copy of the workspace's previous name and does not show a workspace icon with the new name. If ironbar is completely restarted then it shows the correct workspace state. My guess is the code interacting with the Hyperland IPC socket is not watching forrenameworkspaceevents. I would work on a PR for this but I am not yet familiar with Rust :)To Reproduce
Steps to reproduce the behavior:
In Hyprland:
hyprctl dispatch renameworkspace 7 testname.testnameappears.Expected behavior
hyprctl dispatch renameworkspace 7 testname.testnameand no ghost workspace 7. Changing workspaces to workspace id 7 causes thetestnameworkspace to focus.Also as a possible coinciding feature for the Hyprland version of the workspace module I would like to be able to sort the workspaces by their
idproperty which is always its numerical placement, as opposed to alphabetically by itsnameproperty.System information:
ironbar --versionreportsironbar 0.15.0-preConfiguration
Config
Styles
Additional context
Screenshots
https://github.com/JakeStanger/ironbar/assets/85039141/b1a95793-c6fa-4f56-a63d-1066557005a3
In this screen capture,
waybaris the top bar showing the desired behavior and ironbar is on the bottom showing the buggy behavior.@yavko commented on GitHub (Feb 24, 2024):
This seems to be the issue outlined in https://github.com/JakeStanger/ironbar/issues/426#issuecomment-1961011730
@yavko commented on GitHub (Feb 24, 2024):
Hyprland-rs recently had a PR to add
renameworkspace, I'll have to publish a new release, as it's only on master atm, idk about sway though@JakeStanger commented on GitHub (May 3, 2024):
@yavko is this unblocked now that the hyprland-rs v0.4 alpha is out?
@yavko commented on GitHub (May 4, 2024):
Yeah it should all changes from after the last release are, so some optimizations too hopefully
@JakeStanger commented on GitHub (May 5, 2024):
Unfortunately this is still not possible, partly because Hyprland's IPC is a mess and partly because of missing events from hyprland-ipc.
Currently Ironbar is using the v1 events, because the v2 events aren't mapped. This means it's relying on workspace names as identifiers, rather than workspace IDs. Which a) isn't very helpful when the workspace names change, and b) means I cannot easily hook in the
renameworkspaceevent that only provides the ID and not the old name.By adding in some V2 events into hyprland-rs, I should be able to refactor Ironbar to correctly rely on the IDs and get this in. I should get time to do that myself this week.