mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 08:15:21 +01:00
[GH-ISSUE #465] Duplicate icon in launcher #7179
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#7179
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Ithvr on GitHub (Feb 20, 2024).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/465
Describe the bug
I get duplicate icon of some of my favorite applicastion in the launcher widget. I am unsure what the pattern is here since
To Reproduce
Steps to reproduce the behavior:
Expected behavior
System information:
Configuration
Config
Styles
Additional context
Screenshots
@JakeStanger commented on GitHub (Feb 24, 2024):
I think I know what's going on here, but I need some more info to confirm. Are you able to get a list of running clients out, and see what the window class & title for the duplicate actually is please?
I suspect that doesn't match the value in
favoritesso it doesn't know to group them.@Ithvr commented on GitHub (Feb 24, 2024):
I was actually able to fix it earlier today.
I had added "codium" in my favorite list, but when I run
wlrctl toplevel listI saw that codium was namedcodium-url-handler.When I put that line it then it grouped the icon properly. This seems to be case-sensitive since I had to change "alacritty" to "Alacritty".
@JakeStanger commented on GitHub (Feb 24, 2024):
You may well find that although that fixes the grouping, it breaks the ability to launch the program, unless
xdg-openis smart enough to handle that?@Ithvr commented on GitHub (Feb 24, 2024):
From what I can see it seems to work well enough.
All of the icons I have in the launcher is able to start from clicking on the icon.
But while it works I do feel like this is a workaround more then a fix?
For reference this is what I have in my config currently
@JakeStanger commented on GitHub (Feb 25, 2024):
Good to hear, thanks for confirming. Hopefully that saves me a bit of a headache.
Agreed, it's not obvious or ergonomic at the moment. The problem is some windows just don't have names that match their binaries, and it's not very obvious what you should use where without scouting through with your compositor's IPC. I'm open to ideas about how to improve it.
@Ithvr commented on GitHub (Feb 25, 2024):
I have limited knowledge on this, but when I saw trying to trouble shoot this I did see that (most) .desktop files has a
StartupWMClassvariable that might help: https://askubuntu.com/questions/367396/what-does-the-startupwmclass-field-of-a-desktop-file-representWith that said I did see that not all of mine .desktop file had this variable. In this case it was steam and codium-url-handler .desktop files that did not have it.
Mind you I also see that codium have 2 .desktop files, one for codium and one for codium-url-handler.
I don't know if me using NixOS that effects this, but I guess I should put it out there.
@JakeStanger commented on GitHub (Feb 27, 2024):
StartupWMClassis a legacy X11 concept, so it only gets applied to XWayland windows. I think it's also just a hint, and the window can set its class at some point later in the process anyway.In the Wayland world, each window gets an
app_idinstead (so I end up having to look at both because XWayland isn't going away any time soon...).It's not very clear whether Wayland abides by
StartupWMClassat all, and I suspect it's on a per-application level. Still, that's an avenue worth exploring and might catch a few edge-cases, so I'll definitely look into it. Cheers for the pointer.@JakeStanger commented on GitHub (Mar 4, 2024):
As the original issue was resolved, I am going to close this. Future improvements will be tracked in the above issue for clarity.
If you have any further problems let me know and I can re-open, cheers.
@Ithvr commented on GitHub (Mar 5, 2024):
Make sense to centralize it to that issue.
My only opinion for how is that you might want to add a warning in the documentary that says that favorites is case sensitive, and that the window/appid might have a different starting name then expected.