[PR #1144] [MERGED] fix: on_click events not working on button widgets #6802

Closed
opened 2026-05-23 01:57:08 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1144
Author: @JakeStanger
Created: 9/7/2025
Status: Merged
Merged: 9/7/2025
Merged by: @JakeStanger

Base: masterHead: fix/popup-on-click


📝 Commits (1)

  • c2e21d4 fix: on_click events not working on button widgets

📊 Changes

2 files changed (+19 additions, -7 deletions)

View changed files

📝 src/config/common.rs (+18 -6)
📝 src/modules/mod.rs (+1 -1)

📄 Description

For button-type modules, although it was possible to disable the popup, it was not possible to attach an on_click listener. This is now fixed

Fixes #906
Fixes #1112


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1144 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 9/7/2025 **Status:** ✅ Merged **Merged:** 9/7/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/popup-on-click` --- ### 📝 Commits (1) - [`c2e21d4`](https://github.com/JakeStanger/ironbar/commit/c2e21d40c1ad4a4fca73a6f2517172373ee549e5) fix: `on_click` events not working on button widgets ### 📊 Changes **2 files changed** (+19 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/config/common.rs` (+18 -6) 📝 `src/modules/mod.rs` (+1 -1) </details> ### 📄 Description For button-type modules, although it was possible to disable the popup, it was not possible to attach an `on_click` listener. This is now fixed Fixes #906 Fixes #1112 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-23 01:57:08 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#6802
No description provided.