mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 07:15:19 +01:00
[PR #959] Add support to change the volume scrolling on the volume icon #6686
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#6686
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/959
Author: @tglman
Created: 5/6/2025
Status: 🔄 Open
Base:
master← Head:WIP_scroll_volume_change📝 Commits (1)
580b24efeat: add support to change the volume scrolling on the volume icon📊 Changes
3 files changed (+109 additions, -8 deletions)
View changed files
📝
src/clients/volume/mod.rs(+16 -0)📝
src/clients/volume/sink.rs(+39 -1)📝
src/modules/volume.rs(+54 -7)📄 Description
Hi,
This add the ability to turn up and down the volume simply scrolling on the volume icon.
it works now but it's still a bit of a work in progress.
I do not have hardware(for another month) to test scroll with a mouse wheel, I think in that case I need to add a
-for some events, that's why there are two different event signals up and down, otherwise would be enough one change (maybe still can be simplified to only one event).Also I saw the WIP migration of GTK4, maybe is easier to way that the migration is done and then rework this on top of that.
Just opening this to make this feature public, even if not yet mainstream.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.