[PR #855] [MERGED] feat: rename sway_mode to bindmode and add Hyprland support #6617

New issue

Closed

opened 2026-05-23 01:56:37 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 01:56:37 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/855
Author: @Rodrigodd
Created: 1/31/2025
Status: ✅ Merged
Merged: 4/22/2025
Merged by: @JakeStanger

Base: master ← Head: feat/module-bindmode

📝 Commits (3)

5a5b110 feat: rename sway_mode to bindmode and add Hyprland support
638f2a2 refactor: avoid explicity cast with long type
ca3a2e3 ci: add bindmode to feature-checks matrix

📊 Changes

13 files changed (+209 additions, -82 deletions)

View changed files

📝 .github/workflows/build.yml (+3 -0)
📝 Cargo.toml (+6 -0)
📝 docs/GTK4.md (+1 -1)
📝 docs/_Sidebar.md (+1 -1)
📝 docs/modules/Bindmode.md (+12 -12)
📝 src/clients/compositor/hyprland.rs (+58 -21)
📝 src/clients/compositor/mod.rs (+41 -6)
📝 src/clients/compositor/sway.rs (+33 -0)
📝 src/clients/mod.rs (+21 -1)
📝 src/config/mod.rs (+6 -6)
📝 src/modules/bindmode.rs (+25 -31)
📝 src/modules/mod.rs (+2 -2)
➖ src/modules/sway/mod.rs (+0 -1)

📄 Description

I am currently migrating from sway to Hyprland, and so I added support for Hyprland in the sway_mode module. Because the module is no longer sway-only, I decided to rename to a more generic name. This feature does not have a consistent name across window managers, i3/Sway calls it binding mode, while Hyprland calls it Keybind submaps. But "bindmode" appears to be a good enough name.

I made "sway_mode" be a alias for "bindmode" to avoid breaking configs that use the previous name, but I can remove that if you prefer.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/855 **Author:** [@Rodrigodd](https://github.com/Rodrigodd) **Created:** 1/31/2025 **Status:** ✅ Merged **Merged:** 4/22/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `feat/module-bindmode` --- ### 📝 Commits (3) - [`5a5b110`](https://github.com/JakeStanger/ironbar/commit/5a5b110c7aadd670b9bfa14b695d900d9f9ae3d6) feat: rename sway_mode to bindmode and add Hyprland support - [`638f2a2`](https://github.com/JakeStanger/ironbar/commit/638f2a20d2f4901da2333cb18223872f3532341f) refactor: avoid explicity cast with long type - [`ca3a2e3`](https://github.com/JakeStanger/ironbar/commit/ca3a2e31ef920527f74ac8c1c88fe44134aa7dcd) ci: add bindmode to feature-checks matrix ### 📊 Changes **13 files changed** (+209 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+3 -0) 📝 `Cargo.toml` (+6 -0) 📝 `docs/GTK4.md` (+1 -1) 📝 `docs/_Sidebar.md` (+1 -1) 📝 `docs/modules/Bindmode.md` (+12 -12) 📝 `src/clients/compositor/hyprland.rs` (+58 -21) 📝 `src/clients/compositor/mod.rs` (+41 -6) 📝 `src/clients/compositor/sway.rs` (+33 -0) 📝 `src/clients/mod.rs` (+21 -1) 📝 `src/config/mod.rs` (+6 -6) 📝 `src/modules/bindmode.rs` (+25 -31) 📝 `src/modules/mod.rs` (+2 -2) ➖ `src/modules/sway/mod.rs` (+0 -1) </details> ### 📄 Description I am currently migrating from sway to Hyprland, and so I added support for Hyprland in the sway_mode module. Because the module is no longer sway-only, I decided to rename to a more generic name. This feature does not have a consistent name across window managers, i3/Sway [calls it binding mode](https://i3wm.org/docs/userguide.html#binding_modes), while Hyprland calls it [Keybind submaps](https://wiki.hyprland.org/Configuring/Binds/#submaps). But "bindmode" appears to be a good enough name. I made "sway_mode" be a alias for "bindmode" to avoid breaking configs that use the previous name, but I can remove that if you prefer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 01:56:37 +01:00