[PR #283] [MERGED] feat(workspaces): visible CSS selector #603

New issue

Closed

opened 2026-05-22 21:54:02 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 21:54:02 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/283
Author: @malicean
Created: 8/25/2023
Status: ✅ Merged
Merged: 8/26/2023
Merged by: @JakeStanger

Base: master ← Head: feat/workspaces-visible

📝 Commits (1)

25c490b feat(workspaces): visible CSS selector

📊 Changes

5 files changed (+147 additions, -80 deletions)

View changed files

📝 docs/modules/Workspaces.md (+1 -0)
📝 src/clients/compositor/hyprland.rs (+53 -41)
📝 src/clients/compositor/mod.rs (+34 -4)
📝 src/clients/compositor/sway.rs (+33 -13)
📝 src/modules/workspaces.rs (+26 -22)

📄 Description

Adds CSS class visible to all workspace buttons whose workspaces are visible (displayed on a monitor), including the focused workspace. Like focused, the rule is .workspaces .item.visible.

Implementation replaces focused: bool of clients::compositor::Workspace with visibility: Visibility, which represents focused, visible, and hidden (not on a monitor). Both compositors' listeners now fill the changed field, clients::compositor::WorkspaceUpdate::Focus now carries Workspaces rather than workspace names, and modules::workspaces::WorkspacesModule now adds/removes the new CSS class according to the Workspaces.

Fixes #282

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/283 **Author:** [@malicean](https://github.com/malicean) **Created:** 8/25/2023 **Status:** ✅ Merged **Merged:** 8/26/2023 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `feat/workspaces-visible` --- ### 📝 Commits (1) - [`25c490b`](https://github.com/JakeStanger/ironbar/commit/25c490b8b426176c1a4c9d402aafd6783c9b6d48) feat(workspaces): visible CSS selector ### 📊 Changes **5 files changed** (+147 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/Workspaces.md` (+1 -0) 📝 `src/clients/compositor/hyprland.rs` (+53 -41) 📝 `src/clients/compositor/mod.rs` (+34 -4) 📝 `src/clients/compositor/sway.rs` (+33 -13) 📝 `src/modules/workspaces.rs` (+26 -22) </details> ### 📄 Description Adds CSS class `visible` to all workspace buttons whose workspaces are visible (displayed on a monitor), including the focused workspace. Like `focused`, the rule is `.workspaces .item.visible`. Implementation replaces `focused: bool` of `clients::compositor::Workspace` with `visibility: Visibility`, which represents focused, visible, and hidden (not on a monitor). Both compositors' listeners now fill the changed field, `clients::compositor::WorkspaceUpdate::Focus` now carries `Workspace`s rather than workspace names, and `modules::workspaces::WorkspacesModule` now adds/removes the new CSS class according to the `Workspace`s. Fixes #282 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 21:54:02 +01:00