mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 09:15:22 +01:00
[GH-ISSUE #1371] Built-in profiles conflict with user configuration #6028
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#6028
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @itshog on GitHub (Feb 13, 2026).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/1371
As stated in the wiki, the new brightness module ships with default profiles which set the icon according to the percentage. This seems to override the user-specified
formatproperty: in particular, my use case is showing the number without the percentage symbol (I use a vertical bar, so having the "%" symbols takes up unnecessary space and I find it quite ugly), but something like this doesn't work:In fact, I believe that the
formatoption is overridden by the profiles which set the icons. Interestingly though I found out that the only way to override these profiles is by creating a new one for each of the levels mentioned in the wiki: for instance, something like the following only works when the percentage is exactly 30, everything below will still have the built-in formatting with the percentage symbol.I hope this could be fixed, and thanks for the amazing project!
@JakeStanger commented on GitHub (Feb 13, 2026):
Thanks for reporting. I was somewhat aware this was going to be a potential issue but I guess I underestimated it.
I think what we need is the ability to disable the defaults. There's a couple of potential solutions here that I see:
profiles = {}means you'd have a clean slate.use_default_profilesboolean option, which could be set to false to avoid merging in the defaults.Additionally we might want to change the merge behaviour, although I'm struggling to see how that would help in this case. Ideas welcome though
@itshog commented on GitHub (Feb 19, 2026):
This second option seems reasonable to me, especially if the
use_default_profilesoption could be specified per-module, since a user may want to override the built-in profiles (and have a "clean slate") for a module and not for another. Thanks for looking into this!@itshog commented on GitHub (Apr 5, 2026):
After further examination I believe the issue runs deeper than that: in fact, I tried to overwrite every possible brightness profile by specifying a custom profile for each integer from 1 to 100, and some of these profiles still aren't applied.
Now my config looks like this:
But for some reasons the percentage symbol still appears on some values, like 55:
@JakeStanger commented on GitHub (Apr 20, 2026):
I'll be pushing up a PR in a second that adds the new
use_default_profilesoption. Would you be able to give that a go and see if it resolves the original issue please?This makes sense. The default profiles are merged in after the user profile due to some serde limitations. If the names match they are skipped, but your names differ (
50,60instead oflevel50,level60) so the default profile ends up taking priory.