mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 06:15:21 +01:00
[GH-ISSUE #452] Tray module: missing or different sized icons #5772
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#5772
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @undesarrolladormas on GitHub (Feb 13, 2024).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/452
Describe the bug
Some tray icons are not displayed and others have different sizes.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
System information:
Additional context
In the screenshot, the missing icon corresponds to Discord
The largest icon corresponds to asusctl
The KeepassXC app icon never appears, it doesn't even show an empty space, like the Discord icon does
Screenshots

@JakeStanger commented on GitHub (Feb 13, 2024):
Thanks for reporting. Looks like there's still a good way to go before the tray is really there.
@JakeStanger commented on GitHub (Feb 25, 2024):
I've just opened a draft PR that may resolve the incorrectly sized issues. I'm not easily able to replicate the issues myself, so are you able to test the above PR and see if it helps at all please?
The PR also includes a new
icon_sizesetting for the tray module so you can control that if it's too large/small by default.Issues with icons not rendering, or items not showing at all run deeper and are going to take a bit longer to resolve.
@chmanie commented on GitHub (Feb 25, 2024):
Adding the icon_size was a secret wish of mine, thanks for that (the bigger icons are much prettier oftentimes). Cheers 💖
@JakeStanger commented on GitHub (Mar 2, 2024):
@undesarrolladormas hey have you been able to test the PR to see if this resolves the issue?
@undesarrolladormas commented on GitHub (Mar 3, 2024):
I've been testing a bit, the new

icon_sizesetting doesn't prevent that app's icon from getting bigger.e.g. with
icon_size: 25But it allows to make it bigger

e.g. with
icon_size: 80Looking through the project a bit, it looks like they only use 512x512 icons for the tray. Would it have anything to do with that?
@JakeStanger commented on GitHub (Mar 3, 2024):
It could be although I don't get why. I request the image is scaled down to size so being too large shouldn't matter.
The only thing I can think of is that the image isn't actually square. Are you able to double check it's 512x512 please?
If you could also send the image file please, I might be able to fudge something to be able to test it myself.
@undesarrolladormas commented on GitHub (Mar 5, 2024):
You can get the icons from their repository here
Checking one of the icons, it is indeed a 512x512 image
@JakeStanger commented on GitHub (Mar 10, 2024):
Weird, I'm trying that image file directly and it respects
icon_sizeas expected, both smaller and larger. The same goes for the SVGs in the repo so it's not that.Could you share your module config and related styles please, and I'll try those?
@JakeStanger commented on GitHub (Mar 29, 2024):
I have just merged a PR that completely rewrites the tray client code. I'm hoping that will resolve all of the issues you have been experiencing (probably except Discord, which seems to have a bugged tray implementation in its side). Can you let me know how the latest master commit works for you please?
@JakeStanger commented on GitHub (Apr 12, 2024):
Going to close this as I've not heard back, and since the client code has been entirely written I would expect any outstanding issues to now be outdated. If you still have issues, let me know and we can re-open and go from there.